Skip to content

Update BMDB model list - supported / failed#1496

Merged
danv61 merged 6 commits into
masterfrom
dan-bmdb-unsupported
May 12, 2025
Merged

Update BMDB model list - supported / failed#1496
danv61 merged 6 commits into
masterfrom
dan-bmdb-unsupported

Conversation

@danv61
Copy link
Copy Markdown
Contributor

@danv61 danv61 commented May 6, 2025

BMDB models BIOMD0000000355 and BIOMD0000000355 fail to import in vcell because some compartments size are marked as variable, which is unsupported in vcell

@danv61 danv61 requested a review from jcschaff May 9, 2025 16:58
@danv61
Copy link
Copy Markdown
Contributor Author

danv61 commented May 9, 2025

Code to go through all the BMDB models and check if SBML import succeeds
Make lists with new failures, make list with models marked as failures but now csn be imported.

@danv61 danv61 changed the title Dan bmdb unsupported Update BMDB model list - supported / failed May 9, 2025
Copy link
Copy Markdown
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan, looks good. Approved!

If you haven't already, please make a follow-up issue to run the SBML import against all BMDB models periodically (e.g. every week) and make a discrepancy report to send to slack.

@danv61 danv61 merged commit 81be6ec into master May 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants