Field data hot fix#1499
Merged
Merged
Conversation
The file is now part of the specification being uploaded to create field data.
Before deletion would only occur during errors in the file creation portion, but now if any part of the process throws an error attempts to delete will be made.
The JSON version of the User object had extra variables which where set, and did not set the variables which where actually required. Now those extra variables are not included in the JSON and the proper variables are set.
Contributor
Author
|
Suggested Changes:
|
jcschaff
approved these changes
May 9, 2025
jcschaff
left a comment
jcschaff
left a comment
Member
There was a problem hiding this comment.
approved if comment for breaking up error handling is incorporated. approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the following bugs remaining with field data: