Skip to content

KeyValue Serialization, Fix BioModel Save Bug, and Update BioModel Save Input#1523

Merged
Ezequiel-Valencia merged 5 commits intomasterfrom
key-value-searlizes-to-string
Jun 3, 2025
Merged

KeyValue Serialization, Fix BioModel Save Bug, and Update BioModel Save Input#1523
Ezequiel-Valencia merged 5 commits intomasterfrom
key-value-searlizes-to-string

Conversation

@Ezequiel-Valencia
Copy link
Copy Markdown
Contributor

This PR includes the following changes:

  • Made KeyValue no longer an object which is serialized, but instead take it's string value and only send that
  • Make BioModel saving use PropertyLoader so that it can retrieve the software version
  • Update the input method for BioModel save to create a better user experience

@Ezequiel-Valencia Ezequiel-Valencia self-assigned this Jun 3, 2025
@Ezequiel-Valencia Ezequiel-Valencia linked an issue Jun 3, 2025 that may be closed by this pull request
@Ezequiel-Valencia Ezequiel-Valencia linked an issue Jun 3, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with @Ezequiel-Valencia, approved.

@Ezequiel-Valencia Ezequiel-Valencia merged commit 7b81461 into master Jun 3, 2025
13 checks passed
@Ezequiel-Valencia Ezequiel-Valencia deleted the key-value-searlizes-to-string branch June 3, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve BioModel Saving Endpoint Change Key Value Serialization To String

2 participants