Skip to content

Fix NPE in StochMathMapping for symbol-less rate expressions #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcschaff merged 1 commit into from
May 1, 2026
Merged

Fix NPE in StochMathMapping for symbol-less rate expressions #1672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vcell-core/src/main/java/cbit/vcell/mapping/StochMathMapping.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ private Expression getProbabilityRate(ReactionStep reactionStep, GeneralKinetics

// collect symbolTableEntries for speciesContexts within netRateExpr and replace with concentration parameter
netRateExpr = new Expression(netRateExpr);
for (String symbol : netRateExpr.getSymbols()) {
// Expression.getSymbols() returns null when the expression has no free symbols
// (e.g. a constant rate, or a rate that only references already-resolved values).
String[] symbols = netRateExpr.getSymbols();
for (int i = 0; symbols != null && i < symbols.length; i++) {
String symbol = symbols[i];
SymbolTableEntry symbolTableEntry = netRateExpr.getSymbolBinding(symbol);
if (symbolTableEntry instanceof Kinetics.KineticsProxyParameter proxyParameter
&& proxyParameter.getTarget() instanceof SpeciesContext sc) {
Expand Down
Loading