Skip to content

Commit 3d02a43

Browse files
committed
Fix config file locking
1 parent e101118 commit 3d02a43

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

lib/Virtualmin/Config/Plugin/SSL.pm

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ sub actions {
2626
$self->spin();
2727
eval {
2828
foreign_require("virtual-server");
29-
virtual_server::push_all_print();
30-
virtual_server::set_all_null_print();
31-
lock_file($module_config_file);
3229

3330
my $rs = 2;
3431

@@ -57,10 +54,6 @@ sub actions {
5754
virtual_server::delete_virtualmin_default_hostname_ssl();
5855
}
5956

60-
# Save Virtualmin configuration after all changes are made
61-
save_module_config(\%virtual_server::config);
62-
unlock_file($module_config_file);
63-
6457
$self->done($rs); # Maybe OK!
6558
};
6659
if ($@) {

lib/Virtualmin/Config/Plugin/Virtualmin.pm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use parent 'Virtualmin::Config::Plugin';
77

88
our $config_directory;
99
our (%gconfig, %miniserv);
10-
our (%config, $module_config_file);
10+
our (%config, $module_name, $module_config_file);
1111

1212
my $log = Log::Log4perl->get_logger("virtualmin-config-system");
1313

@@ -32,9 +32,9 @@ sub actions {
3232
(defined $self->bundle() && $self->bundle() =~ /mini/i) ?
3333
($self->bundle() =~ /LEMP/i ? 'LEMP' : 'LAMP') : 0;
3434
foreign_require("virtual-server");
35-
virtual_server::push_all_print();
36-
virtual_server::set_all_null_print();
35+
3736
lock_file($module_config_file);
37+
3838
$virtual_server::config{'mail_system'} = 0;
3939
$virtual_server::config{'nopostfix_extra_user'} = 1;
4040
$virtual_server::config{'aliascopy'} = 1;
@@ -137,7 +137,7 @@ sub actions {
137137
}
138138

139139
# Save Virtualmin configuration after all changes are made
140-
save_module_config(\%virtual_server::config);
140+
save_module_config(\%virtual_server::config, $module_name);
141141
unlock_file($module_config_file);
142142

143143
# Setup the Apache, BIND and DB modules to use tables for lists

0 commit comments

Comments
 (0)