fix(extensions): MaskExtension compatilble with TerrainExtension#10187
Open
felixpalmer wants to merge 7 commits intomasterfrom
Open
fix(extensions): MaskExtension compatilble with TerrainExtension#10187felixpalmer wants to merge 7 commits intomasterfrom
felixpalmer wants to merge 7 commits intomasterfrom
Conversation
|
coverage: 83.742% (-0.006%) from 83.748% — felix/mask-with-terrain into master |
felixpalmer
force-pushed
the
felix/mask-with-terrain
branch
from
41d7dfb to
030be26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently if the
MaskExtensionis used withTerrainExtensionno draped layer is drawn. This PR fixes that:also works when masking terrain layer now:
Change List
effects: []inTerrainPassto allowMaskEffectconfiguration throughTerrainEffectfrom including itself aftereffects: []removalTerrainEffectinstead create lazily