fix(arcgis): update arcgis module to use RenderNode instead of externalRenderers#10257
Open
toddrun wants to merge 15 commits into
Open
fix(arcgis): update arcgis module to use RenderNode instead of externalRenderers#10257toddrun wants to merge 15 commits into
toddrun wants to merge 15 commits into
Conversation
Author
|
The build failing is actually good news: it means the luma patch is no longer needed. Unfortunately, I don't have immediate bandwidth available to update the dependencies and remove the patch, but this is definitely on "the list" now |
d1b2e02 to
0fc13c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9497
Background
ArcGIS JS API 4.29 replaced
externalRendererswith the newRenderNodeAPI. The existing@deck.gl/arcgisSceneView integration still depended onexternalRenderers, so this PR ports the integration toRenderNodeand fixes the rendering issues exposed during that migration.Change List
externalRendererstoRenderNode.render()call, which is the earliest point where ArcGIS guarantees a valid WebGL context.RenderNode.coordinateSystemvalues in the core shader path soTile3DLayer/I3SLoadercontinue to work with the newer string-based shader code.Patch@luma.gl/webgl@9.3.2so shared ArcGIS/deck WebGL state is re-read correctly when ArcGIS changes framebuffer bindings.Notes
SceneViewRenderNoderather than the oldexternalRendererspath.The luma patch is applied withpatch-packageduringpostinstall.Verification