Skip to content

fix(core): arm doubleClickDragZoom by coordinating the dblclickdrag recognizer #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charlieforward9 wants to merge 1 commit into from
Closed

fix(core): arm doubleClickDragZoom by coordinating the dblclickdrag recognizer #10417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/core/src/lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ export const RECOGNIZERS = {
pan: [Pan, {threshold: 1}, ['pinch'], ['multipan']],
dblclick: [Tap, {event: 'dblclick', taps: 2}],
click: [Tap, {event: 'click'}, null, ['dblclick']],
dblclickdrag: [DoubleClickDrag, {event: 'dblclickdrag'}]
// Must recognize simultaneously with click/dblclick: otherwise the manager resets
// DoubleClickDrag (clearing its first-tap memory) as soon as those recognizers activate,
// so the second press never matches and the gesture never arms.
dblclickdrag: [DoubleClickDrag, {event: 'dblclickdrag'}, ['dblclick', 'click'], null]
} as const;

export type RecognizerOptions = {
Expand Down
Loading