style: fix RuboCop offenses in specs

- Use do/end blocks instead of braces for multi-line blocks
- Use change(Model, :count) instead of change { Model.count }
- Use receive_messages for multiple stubs
- Use safe navigation operator (&.)
- Remove redundant spec type annotations
- Fix extra spacing

Author: vishaltps

spec/presenters/solid_queue_monitor/jobs_presenter_spec.rb

@@ -10,7 +10,7 @@
     let(:job2) { create(:solid_queue_job, :completed, class_name: 'ReportJob') }
     let(:jobs) { [job1, job2] }
 
-    # Note: These tests require routes which cause duplicate route errors in test environment.
+    # NOTE: These tests require routes which cause duplicate route errors in test environment.
     # Skip for now - the presenter functionality is tested through integration/feature tests.
 
     it 'returns HTML string', skip: 'Route loading issues in test environment' do

spec/requests/solid_queue_monitor/failed_jobs_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe 'Failed Jobs', type: :request do
+RSpec.describe 'Failed Jobs' do
   describe 'GET /failed_jobs' do
     let!(:failed_job1) { create(:solid_queue_failed_execution, created_at: 1.hour.ago) }
     let!(:failed_job2) { create(:solid_queue_failed_execution, created_at: 2.hours.ago) }
@@ -49,9 +49,9 @@
     end
 
     it 'removes the failed execution after retry' do
-      expect {
+      expect do
         post "/retry_failed_job/#{failed_job.id}"
-      }.to change { SolidQueue::FailedExecution.count }.by(-1)
+      end.to change(SolidQueue::FailedExecution, :count).by(-1)
     end
 
     context 'with custom redirect path' do
@@ -73,9 +73,9 @@
     end
 
     it 'removes the failed execution after discard' do
-      expect {
+      expect do
         post "/discard_failed_job/#{failed_job.id}"
-      }.to change { SolidQueue::FailedExecution.count }.by(-1)
+      end.to change(SolidQueue::FailedExecution, :count).by(-1)
     end
   end
 
@@ -115,9 +115,7 @@
 
   context 'with authentication enabled' do
     before do
-      allow(SolidQueueMonitor).to receive(:authentication_enabled).and_return(true)
-      allow(SolidQueueMonitor).to receive(:username).and_return('admin')
-      allow(SolidQueueMonitor).to receive(:password).and_return('password123')
+      allow(SolidQueueMonitor).to receive_messages(authentication_enabled: true, username: 'admin', password: 'password123')
     end
 
     let(:valid_credentials) do

spec/requests/solid_queue_monitor/overview_spec.rb

@@ -2,8 +2,8 @@
 
 require 'spec_helper'
 
-RSpec.describe 'Overview', type: :request do
-  # Note: Tests hit the engine directly at '/' instead of the mounted path '/solid_queue'
+RSpec.describe 'Overview' do
+  # NOTE: Tests hit the engine directly at '/' instead of the mounted path '/solid_queue'
   describe 'GET /' do
     before do
       create_list(:solid_queue_job, 3)
@@ -43,9 +43,7 @@
 
   context 'with authentication enabled' do
     before do
-      allow(SolidQueueMonitor).to receive(:authentication_enabled).and_return(true)
-      allow(SolidQueueMonitor).to receive(:username).and_return('admin')
-      allow(SolidQueueMonitor).to receive(:password).and_return('password123')
+      allow(SolidQueueMonitor).to receive_messages(authentication_enabled: true, username: 'admin', password: 'password123')
     end
 
     it 'requires authentication' do

spec/requests/solid_queue_monitor/queues_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe 'Queues', type: :request do
+RSpec.describe 'Queues' do
   describe 'GET /queues' do
     before do
       create(:solid_queue_job, queue_name: 'default')
@@ -48,9 +48,9 @@
       end
 
       it 'creates a pause record' do
-        expect {
+        expect do
           post '/pause_queue', params: { queue_name: queue_name }
-        }.to change { SolidQueue::Pause.count }.by(1)
+        end.to change(SolidQueue::Pause, :count).by(1)
       end
     end
 
@@ -60,9 +60,9 @@
       end
 
       it 'does not create another pause record' do
-        expect {
+        expect do
           post '/pause_queue', params: { queue_name: queue_name }
-        }.not_to change { SolidQueue::Pause.count }
+        end.not_to(change(SolidQueue::Pause, :count))
       end
 
       it 'still redirects to queues' do
@@ -89,17 +89,17 @@
       end
 
       it 'removes the pause record' do
-        expect {
+        expect do
           post '/resume_queue', params: { queue_name: queue_name }
-        }.to change { SolidQueue::Pause.count }.by(-1)
+        end.to change(SolidQueue::Pause, :count).by(-1)
       end
     end
 
     context 'when queue is not paused' do
       it 'does not change pause count' do
-        expect {
+        expect do
           post '/resume_queue', params: { queue_name: queue_name }
-        }.not_to change { SolidQueue::Pause.count }
+        end.not_to(change(SolidQueue::Pause, :count))
       end
 
       it 'still redirects to queues' do
@@ -112,9 +112,7 @@
 
   context 'with authentication enabled' do
     before do
-      allow(SolidQueueMonitor).to receive(:authentication_enabled).and_return(true)
-      allow(SolidQueueMonitor).to receive(:username).and_return('admin')
-      allow(SolidQueueMonitor).to receive(:password).and_return('password123')
+      allow(SolidQueueMonitor).to receive_messages(authentication_enabled: true, username: 'admin', password: 'password123')
     end
 
     it 'requires authentication for queues index' do

spec/spec_helper.rb

@@ -115,7 +115,7 @@ def app
       @app ||= Rack::Builder.new do
         use ActionDispatch::Session::CookieStore,
             key: '_test_session',
-            secret: 'a' * 64  # 64 byte secret for testing
+            secret: 'a' * 64 # 64 byte secret for testing
         run SolidQueueMonitor::Engine
       end.to_app
     end

spec/support/solid_queue_stubs.rb

@@ -4,86 +4,88 @@
 # This file should be loaded after ActiveRecord is available but before
 # any code tries to use SolidQueue models
 
-module SolidQueue
-  class ApplicationRecord < ActiveRecord::Base
-    self.abstract_class = true
-  end
+unless defined?(SolidQueue)
+  module SolidQueue
+    class ApplicationRecord < ActiveRecord::Base
+      self.abstract_class = true
+    end
 
-  class Job < ApplicationRecord
-    self.table_name = 'solid_queue_jobs'
+    class Job < ApplicationRecord
+      self.table_name = 'solid_queue_jobs'
 
-    has_one :ready_execution, dependent: :destroy
-    has_one :scheduled_execution, dependent: :destroy
-    has_one :failed_execution, dependent: :destroy
-    has_one :claimed_execution, dependent: :destroy
+      has_one :ready_execution, dependent: :destroy
+      has_one :scheduled_execution, dependent: :destroy
+      has_one :failed_execution, dependent: :destroy
+      has_one :claimed_execution, dependent: :destroy
 
-    def failed?
-      failed_execution.present?
+      def failed?
+        failed_execution.present?
+      end
     end
-  end
-
-  class ReadyExecution < ApplicationRecord
-    self.table_name = 'solid_queue_ready_executions'
-    belongs_to :job
-  end
 
-  class ScheduledExecution < ApplicationRecord
-    self.table_name = 'solid_queue_scheduled_executions'
-    belongs_to :job
-  end
-
-  class FailedExecution < ApplicationRecord
-    self.table_name = 'solid_queue_failed_executions'
-    belongs_to :job
+    class ReadyExecution < ApplicationRecord
+      self.table_name = 'solid_queue_ready_executions'
+      belongs_to :job
+    end
 
-    def retry
-      # Stub implementation for testing
-      job.update(finished_at: nil) if job
-      destroy
-      true
+    class ScheduledExecution < ApplicationRecord
+      self.table_name = 'solid_queue_scheduled_executions'
+      belongs_to :job
     end
 
-    def discard
-      job&.update(finished_at: Time.current)
-      destroy
-      true
+    class FailedExecution < ApplicationRecord
+      self.table_name = 'solid_queue_failed_executions'
+      belongs_to :job
+
+      def retry
+        # Stub implementation for testing
+        job&.update(finished_at: nil)
+        destroy
+        true
+      end
+
+      def discard
+        job&.update(finished_at: Time.current)
+        destroy
+        true
+      end
     end
-  end
 
-  class ClaimedExecution < ApplicationRecord
-    self.table_name = 'solid_queue_claimed_executions'
-    belongs_to :job
-  end
+    class ClaimedExecution < ApplicationRecord
+      self.table_name = 'solid_queue_claimed_executions'
+      belongs_to :job
+    end
 
-  class Pause < ApplicationRecord
-    self.table_name = 'solid_queue_pauses'
-  end
+    class Pause < ApplicationRecord
+      self.table_name = 'solid_queue_pauses'
+    end
 
-  class RecurringTask < ApplicationRecord
-    self.table_name = 'solid_queue_recurring_tasks'
-  end
+    class RecurringTask < ApplicationRecord
+      self.table_name = 'solid_queue_recurring_tasks'
+    end
 
-  class Process < ApplicationRecord
-    self.table_name = 'solid_queue_processes'
-  end
+    class Process < ApplicationRecord
+      self.table_name = 'solid_queue_processes'
+    end
 
-  class Queue
-    attr_reader :name
+    class Queue
+      attr_reader :name
 
-    def initialize(name)
-      @name = name
-    end
+      def initialize(name)
+        @name = name
+      end
 
-    def paused?
-      Pause.exists?(queue_name: @name)
-    end
+      def paused?
+        Pause.exists?(queue_name: @name)
+      end
 
-    def pause
-      Pause.find_or_create_by(queue_name: @name)
-    end
+      def pause
+        Pause.find_or_create_by(queue_name: @name)
+      end
 
-    def resume
-      Pause.where(queue_name: @name).destroy_all
+      def resume
+        Pause.where(queue_name: @name).destroy_all
+      end
     end
   end
-end unless defined?(SolidQueue)
+end