Commit fbb65cb
authored
v2.0.0: Rails conventions refactor (#38)
* refactor: migrate dashboard rendering to ERB views (WIP)
Replaces 11 *Presenter classes with app/views/**.html.erb plus
app/helpers/solid_queue_monitor/* helpers. Serves CSS/JS via a new
AssetsController with content-hashed URLs, removing the need for
inline <style nonce>/<script nonce> blocks. Public API unchanged
(config block, mount, URLs, auth, CSP nonce support).
WIP: jobs#show specs failing with MissingExactTemplate despite the
template existing — diagnosis + Phase 6 cleanup + version bump still
pending in follow-up commits.
* chore: phase 6 cleanup + bump to 2.0.0
- Delete BasePresenter, StatsPresenter, HtmlGenerator, StylesheetGenerator
(~2,750 LOC of legacy HTML-in-Ruby removed)
- Remove BaseController#render_page (replaced by Rails implicit rendering)
- Upgrade CSP spec with no-inline-style-block / no-inline-script-block assertions
- Bump VERSION to 2.0.0
- Add CHANGELOG entry for [2.0.0] - 2026-05-12
- Refine job_details + jobs helpers and 3 job partials
* fix: readable dark-theme colors for paused queue row
The .queue-paused row only set a light cream background (#fffbeb)
without an explicit text color, so the dark theme inherited the
near-white default text and rendered as nearly invisible. Adds a
dark-theme override with dark amber background + light amber text
(~11:1 contrast). Light theme unchanged.
* chore: gitignore Codex agent files
* docs: update CSP section in README for v2.0
Reflects v2.0 behavior: strict `script-src 'self'; style-src 'self'`
works out of the box now that CSS/JS are served as external assets.
Removes the v1.3.0 caveat about nonces being required for strict
policies, and adds an upgrade note for v1.x users.
* docs: bump Gemfile example to ~> 2.0 in README installation section
* test: add request specs for ready/in_progress/scheduled/recurring jobs
These four index-only controllers lacked dedicated request specs in v1.x.
The refactor inherited the gap. Each new spec covers: happy path, empty
state, key DOM elements, filter by class_name (and queue_name for
ready_jobs).
Brings spec total from 294 to 315 examples.1 parent dee0e61 commit fbb65cb
109 files changed
Lines changed: 2959 additions & 3963 deletions
File tree
- app
- assets
- javascripts/solid_queue_monitor
- stylesheets/solid_queue_monitor
- controllers/solid_queue_monitor
- helpers/solid_queue_monitor
- presenters/solid_queue_monitor
- services/solid_queue_monitor
- views
- layouts/solid_queue_monitor
- solid_queue_monitor
- failed_jobs
- in_progress_jobs
- jobs
- overview
- queues
- ready_jobs
- recurring_jobs
- scheduled_jobs
- search
- workers
- config
- lib/solid_queue_monitor
- spec
- helpers/solid_queue_monitor
- presenters/solid_queue_monitor
- requests/solid_queue_monitor
- services/solid_queue_monitor
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
3 | 24 | | |
4 | 25 | | |
5 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
| 211 | + | |
212 | 212 | | |
213 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
214 | 228 | | |
215 | 229 | | |
216 | 230 | | |
| |||
223 | 237 | | |
224 | 238 | | |
225 | 239 | | |
226 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
227 | 243 | | |
228 | 244 | | |
229 | 245 | | |
| |||
0 commit comments