[BUGFIX] Ignore errors in CloudinaryScanCommand

Author: dhuf

Classes/Command/CloudinaryScanCommand.php

@@ -88,13 +88,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             );
         }
 
-        $message = "Statistics for files: \n\n- created: %s\n- updated: %s\n- total: %s\n- deleted: %s";
+        $message = "Statistics for files: \n\n- created: %s\n- updated: %s\n- total: %s\n- deleted: %s\n- failed: %s";
         $message .= "\n\nStatistics for folders: \n\n- deleted: %s";
         $this->success($message, [
             $result['created'],
             $result['updated'],
             $result['total'],
             $result['deleted'],
+            $result['failed'],
             $result['folder_deleted'],
         ]);
 

Classes/Services/CloudinaryScanService.php

@@ -30,6 +30,7 @@ class CloudinaryScanService
     private const UPDATED = 'updated';
     private const DELETED = 'deleted';
     private const TOTAL = 'total';
+    private const FAILED = 'failed';
     private const FOLDER_DELETED = 'folder_deleted';
 
     /**
@@ -55,6 +56,7 @@ class CloudinaryScanService
         self::UPDATED => 0,
         self::DELETED => 0,
         self::TOTAL => 0,
+        self::FAILED => 0,
 
         self::FOLDER_DELETED => 0,
     ];
@@ -143,34 +145,42 @@ public function scan(): array
 
             if (is_array($response['resources'])) {
                 foreach ($response['resources'] as $resource) {
-
                     $fileIdentifier = $this->getCloudinaryPathService()->computeFileIdentifier($resource);
-                    if ($this->io) {
-                        $this->io->writeln($fileIdentifier);
-                    }
+                    try {
+                        if ($this->io) {
+                            $this->io->writeln($fileIdentifier);
+                        }
 
-                    // Save mirrored file
-                    $result = $this->getCloudinaryResourceService()->save($resource);
+                        // Save mirrored file
+                        $result = $this->getCloudinaryResourceService()->save($resource);
 
-                    // Find if the file exists in sys_file already
-                    if (!$this->fileExistsInStorage($fileIdentifier)) {
+                        // Find if the file exists in sys_file already
+                        if (!$this->fileExistsInStorage($fileIdentifier)) {
 
-                        if ($this->io) {
-                            $this->io->writeln('Indexing new file: ' . $fileIdentifier);
-                            $this->io->writeln('');
-                        }
+                            if ($this->io) {
+                                $this->io->writeln('Indexing new file: ' . $fileIdentifier);
+                                $this->io->writeln('');
+                            }
 
-                        // This will trigger a file indexation
-                        $this->storage->getFile($fileIdentifier);
-                    }
+                            // This will trigger a file indexation
+                            $this->storage->getFile($fileIdentifier);
+                        }
 
-                    // For the stats, we collect the number of files touched
-                    $key = key($result);
-                    $this->statistics[$key] += $result[$key];
+                        // For the stats, we collect the number of files touched
+                        $key = key($result);
+                        $this->statistics[$key] += $result[$key];
 
-                    // In any case we can add a file to the counter.
-                    // Later we can verify the total corresponds to the "created" + "updated" + "deleted" files
-                    $this->statistics[self::TOTAL]++;
+                        // In any case we can add a file to the counter.
+                        // Later we can verify the total corresponds to the "created" + "updated" + "deleted" files
+                        $this->statistics[self::TOTAL]++;
+                    }
+                    catch (\Exception $e) {
+                        $this->statistics[self::FAILED]++;
+                        if ($this->io) {
+                            $this->io->warning(sprintf('Error could not process "%s"', $fileIdentifier));
+                        }
+                        // ignore
+                    }
                 }
             }
         } while (!empty($response) && isset($response['next_cursor']));