Skip to content

Commit e5e20a6

Browse files
authored
chore: address sonarlint issues (#248)
Signed-off-by: Alan Brault <alan.brault@visus.io>
1 parent ae50b68 commit e5e20a6

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ resharper_convert_to_primary_constructor_highlighting = none
237237

238238
# Meziantou Rules
239239
dotnet_diagnostic.MA0003.severity = none
240+
dotnet_diagnostic.MA0038.severity = none
240241

241242
#### Razor Files ####
242243

src/Visus.AddressValidation.Integration.Google/Serialization/Json/ApiResponseJsonSerializerContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ namespace Visus.AddressValidation.Integration.Google.Serialization.Json;
88
[JsonSerializable(typeof(ApiErrorResponse))]
99
[JsonSerializable(typeof(ApiResponse))]
1010
[JsonSourceGenerationOptions(WriteIndented = false, PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase)]
11-
internal partial class ApiResponseJsonSerializerContext : JsonSerializerContext;
11+
internal sealed partial class ApiResponseJsonSerializerContext : JsonSerializerContext;

src/Visus.AddressValidation/Services/AbstractAuthenticationService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public string? CacheKey
9999
cancellationToken)
100100
.ConfigureAwait(false);
101101

102-
if ( !factoryRan )
102+
if ( !factoryRan ) // NOSONAR S2583 - false positive: factoryRan is mutated inside the async lambda above
103103
{
104104
return string.IsNullOrWhiteSpace(tokenResponse?.AccessToken) ? null : tokenResponse.AccessToken;
105105
}

0 commit comments

Comments
 (0)