fix: prevent shortcut editor from creating override when unchanged#282
Merged
antfu merged 1 commit intovitejs:mainfrom Apr 8, 2026
Merged
Conversation
Compare edited key against default before saving. Skip writing to commandShortcuts when the value matches the preset, avoiding the false "modified" indicator (reset icon) on unchanged shortcuts.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the shortcuts editor UX by avoiding writing a commandShortcuts override when the edited shortcut matches the command’s default keybinding, preventing unchanged shortcuts from being flagged as “modified” (showing the reset icon).
Changes:
- Add a helper to resolve a command’s default keybinding from the commands registry.
- Update shortcut save logic to delete an existing override (or skip writing) when the saved key equals the default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compare edited key against default before saving. Skip writing to
commandShortcuts when the value matches the preset, avoiding the
false "modified" indicator (reset icon) on unchanged shortcuts.
Linked Issues
Additional context