fix(core): redirect devtools mount path to trailing slash#305
Merged
Conversation
onmax
force-pushed
the
fix-devtools-trailing-slash
branch
from
b50f16f to
8948b3d
Compare
onmax
changed the title
onmax
force-pushed
the
fix-devtools-trailing-slash
branch
from
8948b3d to
e1b8f0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the standalone DevTools URL without a trailing slash currently serves the DevTools HTML at
/.devtools, but the HTML references assets with relative./assets/...URLs. Browsers resolve those relative to the parent path and request/assets/...instead of/.devtools/assets/..., which causes JS/CSS MIME errors and a blank screen.This redirects the exact DevTools mount path to the canonical directory URL while preserving query strings. Subpaths such as auth and assets continue to be handled by the existing middleware.
Probably there is better solutions, so I am open for another approach