fix: correct the return value of parseReadablePath on Windows#75
Merged
antfu merged 2 commits intoAug 12, 2025
Merged
Conversation
antfu
approved these changes
Aug 12, 2025
liangmiQwQ
added a commit
to liangmiQwQ/vite-devtools
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parseReadablePathfunction inapp/utils/filepath.tswill check if the path match regex/^\w+:/in order to match the path likerolldown:*However, the Windows' path will also match the regex, I think it may be unexpected. The node_modules filters(in TODO #12 ) feat won't work with it in the future because of the wrong module name
Fixes
Added a regex for Windows' path
One more thing: If it really is a bug, I will make a test file for it