-
-
Notifications
You must be signed in to change notification settings - Fork 263
Expand file tree
/
Copy pathhoist.test.ts
More file actions
550 lines (472 loc) · 15.4 KB
/
Copy pathhoist.test.ts
File metadata and controls
550 lines (472 loc) · 15.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
import path from 'node:path'
import { parseAstAsync } from 'vite'
import { describe, expect, it } from 'vitest'
import { transformHoistInlineDirective } from './hoist'
import { debugSourceMap } from './test-utils'
describe('fixtures', () => {
const fixtures = import.meta.glob(
['./fixtures/hoist/**/*.js', '!**/*.snap.*'],
{
query: 'raw',
},
)
async function transformFixture(
input: string,
options?: { encode?: boolean },
) {
const ast = await parseAstAsync(input)
const { output } = transformHoistInlineDirective(input, ast, {
directive: 'use server',
runtime: (value, name) =>
`$$register(${value}, "<id>", ${JSON.stringify(name)})`,
encode: options?.encode ? (v) => `__enc(${v})` : undefined,
decode: options?.encode ? (v) => `__dec(${v})` : undefined,
})
if (!output.hasChanged()) {
return '/* NO CHANGE */'
}
const transformed = output.toString()
// verify transform produces valid js
await parseAstAsync(transformed)
return transformed
}
for (const [file, mod] of Object.entries(fixtures)) {
it(path.basename(file), async () => {
const input = ((await mod()) as any).default as string
await expect
.soft(await transformFixture(input))
.toMatchFileSnapshot(file + '.snap.js')
await expect
.soft(await transformFixture(input, { encode: true }))
.toMatchFileSnapshot(file + '.snap.encode.js')
})
}
})
describe(transformHoistInlineDirective, () => {
async function testTransform(
input: string,
options?: {
encode?: boolean
noExport?: boolean
directive?: string | RegExp
rejectForbiddenExpressions?: boolean
},
) {
const ast = await parseAstAsync(input)
const { output } = transformHoistInlineDirective(input, ast, {
runtime: (value, name, meta) =>
`$$register(${value}, "<id>", ${JSON.stringify(name)}` +
`${
options?.directive instanceof RegExp
? `, ${JSON.stringify(meta)}`
: ''
})`,
directive: options?.directive ?? 'use server',
encode: options?.encode ? (v) => `__enc(${v})` : undefined,
decode: options?.encode ? (v) => `__dec(${v})` : undefined,
noExport: options?.noExport,
rejectForbiddenExpressions: options?.rejectForbiddenExpressions,
})
if (!output.hasChanged()) {
return
}
if (process.env['DEBUG_SOURCEMAP']) {
await debugSourceMap(output)
}
const transformed = output.toString()
await parseAstAsync(transformed)
return transformed
}
async function testTransformNames(input: string) {
const ast = await parseAstAsync(input)
const result = transformHoistInlineDirective(input, ast, {
runtime: (value, name) =>
`$$register(${value}, "<id>", ${JSON.stringify(name)})`,
directive: 'use server',
})
return result.names
}
it('none', async () => {
const input = `
const x = "x";
async function f() {
return x;
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`undefined`)
})
it('top level', async () => {
const input = `
const x = "x";
async function f() {
"use server";
return x;
}
async function g() {
}
export async function h(formData) {
"use server";
return formData.get(x);
}
export default function w() {
"use server";
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"
const x = "x";
const f = /* #__PURE__ */ $$register($$hoist_0_f, "<id>", "$$hoist_0_f");
async function g() {
}
export const h = /* #__PURE__ */ $$register($$hoist_1_h, "<id>", "$$hoist_1_h");
const w = /* #__PURE__ */ $$register($$hoist_2_w, "<id>", "$$hoist_2_w");
export default w;
;export async function $$hoist_0_f() {
"use server";
return x;
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_f, "name", { value: "f" });
;export async function $$hoist_1_h(formData) {
"use server";
return formData.get(x);
};
/* #__PURE__ */ Object.defineProperty($$hoist_1_h, "name", { value: "h" });
;export function $$hoist_2_w() {
"use server";
};
/* #__PURE__ */ Object.defineProperty($$hoist_2_w, "name", { value: "w" });
"
`)
// nothing to encode
expect(await testTransform(input, { encode: true })).toBe(
await testTransform(input),
)
expect(await testTransformNames(input)).toMatchInlineSnapshot(`
[
"$$hoist_0_f",
"$$hoist_1_h",
"$$hoist_2_w",
]
`)
})
it('closure', async () => {
const input = `
let count = 0;
function Counter() {
const name = "value";
async function changeCount(formData) {
"use server";
count += Number(formData.get(name));
}
return "something";
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"
let count = 0;
function Counter() {
const name = "value";
const changeCount = /* #__PURE__ */ $$register($$hoist_0_changeCount, "<id>", "$$hoist_0_changeCount").bind(null, name);
return "something";
}
;export async function $$hoist_0_changeCount(name, formData) {
"use server";
count += Number(formData.get(name));
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_changeCount, "name", { value: "changeCount" });
"
`)
})
it('many', async () => {
const input = `
let count = 0;
function Counter() {
const name = "value";
async function changeCount(formData) {
"use server";
count += Number(formData.get(name));
}
async function changeCount2(formData) {
"use server";
count += Number(formData.get(name));
}
return "something";
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"
let count = 0;
function Counter() {
const name = "value";
const changeCount = /* #__PURE__ */ $$register($$hoist_0_changeCount, "<id>", "$$hoist_0_changeCount").bind(null, name);
const changeCount2 = /* #__PURE__ */ $$register($$hoist_1_changeCount2, "<id>", "$$hoist_1_changeCount2").bind(null, name);
return "something";
}
;export async function $$hoist_0_changeCount(name, formData) {
"use server";
count += Number(formData.get(name));
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_changeCount, "name", { value: "changeCount" });
;export async function $$hoist_1_changeCount2(name, formData) {
"use server";
count += Number(formData.get(name));
};
/* #__PURE__ */ Object.defineProperty($$hoist_1_changeCount2, "name", { value: "changeCount2" });
"
`)
})
it('arrow', async () => {
const input = `
let count = 0;
function Counter() {
const name = "value";
return {
type: "form",
action: (formData) => {
"use server";
count += Number(formData.get(name));
}
}
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"
let count = 0;
function Counter() {
const name = "value";
return {
type: "form",
action: /* #__PURE__ */ $$register($$hoist_0_anonymous_server_function, "<id>", "$$hoist_0_anonymous_server_function").bind(null, name)
}
}
;export function $$hoist_0_anonymous_server_function(name, formData) {
"use server";
count += Number(formData.get(name));
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_anonymous_server_function, "name", { value: "anonymous_server_function" });
"
`)
expect(await testTransform(input, { encode: true })).toMatchInlineSnapshot(`
"
let count = 0;
function Counter() {
const name = "value";
return {
type: "form",
action: /* #__PURE__ */ $$register($$hoist_0_anonymous_server_function, "<id>", "$$hoist_0_anonymous_server_function").bind(null, __enc([name]))
}
}
;export function $$hoist_0_anonymous_server_function($$hoist_encoded, formData) {
const [name] = __dec($$hoist_encoded);
"use server";
count += Number(formData.get(name));
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_anonymous_server_function, "name", { value: "anonymous_server_function" });
"
`)
})
it('higher order', async () => {
// packages/react-server/examples/next/app/actions/header/page.tsx
// packages/react-server/examples/next/app/actions/header/validator.ts
const input = `
export default function Page() {
const x = 0;
const action = validator(async (y) => {
"use server";
return x + y;
})
}
function validator(action) {
return async function (arg) {
"use server";
return action(arg);
};
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"
export default function Page() {
const x = 0;
const action = validator(/* #__PURE__ */ $$register($$hoist_0_anonymous_server_function, "<id>", "$$hoist_0_anonymous_server_function").bind(null, x))
}
function validator(action) {
return /* #__PURE__ */ $$register($$hoist_1_anonymous_server_function, "<id>", "$$hoist_1_anonymous_server_function").bind(null, action);
}
;export async function $$hoist_0_anonymous_server_function(x, y) {
"use server";
return x + y;
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_anonymous_server_function, "name", { value: "anonymous_server_function" });
;export async function $$hoist_1_anonymous_server_function(action, arg) {
"use server";
return action(arg);
};
/* #__PURE__ */ Object.defineProperty($$hoist_1_anonymous_server_function, "name", { value: "anonymous_server_function" });
"
`)
expect(await testTransform(input, { encode: true })).toMatchInlineSnapshot(`
"
export default function Page() {
const x = 0;
const action = validator(/* #__PURE__ */ $$register($$hoist_0_anonymous_server_function, "<id>", "$$hoist_0_anonymous_server_function").bind(null, __enc([x])))
}
function validator(action) {
return /* #__PURE__ */ $$register($$hoist_1_anonymous_server_function, "<id>", "$$hoist_1_anonymous_server_function").bind(null, __enc([action]));
}
;export async function $$hoist_0_anonymous_server_function($$hoist_encoded, y) {
const [x] = __dec($$hoist_encoded);
"use server";
return x + y;
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_anonymous_server_function, "name", { value: "anonymous_server_function" });
;export async function $$hoist_1_anonymous_server_function($$hoist_encoded, arg) {
const [action] = __dec($$hoist_encoded);
"use server";
return action(arg);
};
/* #__PURE__ */ Object.defineProperty($$hoist_1_anonymous_server_function, "name", { value: "anonymous_server_function" });
"
`)
})
// edge case found in https://github.com/remix-run/react-router/blob/98367e49900701c460cb08eb16c2441da5007efc/playground/rsc-vite/src/routes/home/home.tsx
it('export before import', async () => {
const input = `
export {} from "edge-case";
import { redirect } from "react-router/rsc";
export default () => {
const redirectOnServer = async () => {
"use server";
throw redirect();
};
}
`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"
export {} from "edge-case";
import { redirect } from "react-router/rsc";
export default () => {
const redirectOnServer = /* #__PURE__ */ $$register($$hoist_0_redirectOnServer, "<id>", "$$hoist_0_redirectOnServer");
}
;export async function $$hoist_0_redirectOnServer() {
"use server";
throw redirect();
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_redirectOnServer, "name", { value: "redirectOnServer" });
"
`)
})
it('noExport', async () => {
const input = `
export async function test() {
"use cache";
return "test";
}
`
expect(
await testTransform(input, {
directive: 'use cache',
noExport: true,
}),
).toMatchInlineSnapshot(`
"
export const test = /* #__PURE__ */ $$register($$hoist_0_test, "<id>", "$$hoist_0_test");
;async function $$hoist_0_test() {
"use cache";
return "test";
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_test, "name", { value: "test" });
"
`)
})
it('directive pattern', async () => {
const input = `
export async function none() {
"use cache";
return "test";
}
export async function fs() {
"use cache: fs";
return "test";
}
export async function kv() {
"use cache: kv";
return "test";
}
`
expect(
await testTransform(input, {
directive: /^use cache(: .+)?$/,
noExport: true,
}),
).toMatchInlineSnapshot(`
"
export const none = /* #__PURE__ */ $$register($$hoist_0_none, "<id>", "$$hoist_0_none", {"directiveMatch":["use cache",null]});
export const fs = /* #__PURE__ */ $$register($$hoist_1_fs, "<id>", "$$hoist_1_fs", {"directiveMatch":["use cache: fs",": fs"]});
export const kv = /* #__PURE__ */ $$register($$hoist_2_kv, "<id>", "$$hoist_2_kv", {"directiveMatch":["use cache: kv",": kv"]});
;async function $$hoist_0_none() {
"use cache";
return "test";
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_none, "name", { value: "none" });
;async function $$hoist_1_fs() {
"use cache: fs";
return "test";
};
/* #__PURE__ */ Object.defineProperty($$hoist_1_fs, "name", { value: "fs" });
;async function $$hoist_2_kv() {
"use cache: kv";
return "test";
};
/* #__PURE__ */ Object.defineProperty($$hoist_2_kv, "name", { value: "kv" });
"
`)
})
it('no ending new line', async () => {
const input = `\
export async function test() {
"use server";
}`
expect(await testTransform(input)).toMatchInlineSnapshot(`
"export const test = /* #__PURE__ */ $$register($$hoist_0_test, "<id>", "$$hoist_0_test");
;export async function $$hoist_0_test() {
"use server";
};
/* #__PURE__ */ Object.defineProperty($$hoist_0_test, "name", { value: "test" });
"
`)
})
it.each([
['this', `async function action() { "use server"; return this }`],
['arguments', `async function action() { "use server"; return arguments }`],
[
'super',
`class Base { method() {} } class Actions extends Base { static async action() { "use server"; return super.method() } }`,
],
])('rejects lexical %s expressions when requested', async (_name, input) => {
await expect(
testTransform(input, { rejectForbiddenExpressions: true }),
).rejects.toThrow(/cannot use/)
})
it('does not inspect nested function scopes', async () => {
const input = `
async function action() {
"use server";
return function nested() { return this }
}
`
await expect(
testTransform(input, { rejectForbiddenExpressions: true }),
).resolves.toContain('function nested() { return this }')
})
it('allows JSX dev source metadata this arguments', async () => {
const input = `
async function action() {
"use server";
return _jsxDEV("div", {}, undefined, false, undefined, this)
}
`
await expect(
testTransform(input, { rejectForbiddenExpressions: true }),
).resolves.toContain('_jsxDEV')
})
})