Skip to content

Commit 1c7c791

Browse files
hi-ogawaclaude
andcommitted
refactor: rename "deep cjs" to "transitive cjs" throughout codebase
Updates naming to better reflect the nature of CommonJS dependencies that are transitively imported through other packages. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent ce38b15 commit 1c7c791

9 files changed

Lines changed: 34 additions & 32 deletions

File tree

packages/plugin-rsc/e2e/basic.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -824,7 +824,9 @@ function defineTest(f: Fixture) {
824824
test('transitive cjs dep', async ({ page }) => {
825825
await page.goto(f.url())
826826
await waitForHydration(page)
827-
await expect(page.getByTestId('deep-cjs-client')).toHaveText('ok:browser')
827+
await expect(page.getByTestId('transitive-cjs-client')).toHaveText(
828+
'ok:browser',
829+
)
828830
})
829831

830832
test('use cache function', async ({ page }) => {

packages/plugin-rsc/examples/basic/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@types/react": "^19.1.8",
2222
"@types/react-dom": "^19.1.6",
2323
"@vitejs/plugin-react": "latest",
24-
"@vitejs/test-dep-deep-cjs": "file:./test-dep/deep-cjs",
24+
"@vitejs/test-dep-transitive-cjs": "file:./test-dep/transitive-cjs",
2525
"@vitejs/test-dep-client-in-server": "file:./test-dep/client-in-server",
2626
"@vitejs/test-dep-client-in-server2": "file:./test-dep/client-in-server2",
2727
"@vitejs/test-dep-server-in-client": "file:./test-dep/server-in-client",

packages/plugin-rsc/examples/basic/src/routes/deps/deep-cjs/client.tsx

Lines changed: 0 additions & 12 deletions
This file was deleted.
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
'use client'
2+
3+
// @ts-ignore
4+
import { TestClient } from '@vitejs/test-dep-transitive-cjs/client'
5+
6+
export function TestTransitiveCjsClient() {
7+
return (
8+
<div>
9+
[test-dep-transitive-cjs-client: <TestClient />]
10+
</div>
11+
)
12+
}

packages/plugin-rsc/examples/basic/src/routes/root.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { TestTemporaryReference } from './temporary-reference/client'
2929
import { TestUseCache } from './use-cache/server'
3030
import { TestHydrationMismatch } from './hydration-mismatch/server'
3131
import { TestBrowserOnly } from './browser-only/client'
32-
import { TestDeepCjsClient } from './deps/deep-cjs/client'
32+
import { TestTransitiveCjsClient } from './deps/transitive-cjs/client'
3333

3434
export function Root(props: { url: URL }) {
3535
return (
@@ -68,7 +68,7 @@ export function Root(props: { url: URL }) {
6868
<TestClientInServer />
6969
<TestServerInServer />
7070
<TestServerInClient />
71-
<TestDeepCjsClient />
71+
<TestTransitiveCjsClient />
7272
<TestActionStateServer />
7373
<TestModuleInvalidationServer />
7474
<TestBrowserOnly />

packages/plugin-rsc/examples/basic/test-dep/deep-cjs/client.js renamed to packages/plugin-rsc/examples/basic/test-dep/transitive-cjs/client.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export function TestClient() {
2020
return h(
2121
'span',
2222
{
23-
'data-testid': 'deep-cjs-client',
23+
'data-testid': 'transitive-cjs-client',
2424
},
2525
value,
2626
)

packages/plugin-rsc/examples/basic/test-dep/deep-cjs/package.json renamed to packages/plugin-rsc/examples/basic/test-dep/transitive-cjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@vitejs/test-dep-deep-cjs",
2+
"name": "@vitejs/test-dep-transitive-cjs",
33
"private": true,
44
"type": "module",
55
"exports": {

packages/plugin-rsc/examples/basic/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export default { fetch: handler };
154154
// TODO: this should be somehow auto inferred or at least show a warning
155155
// to guide users to `optimizeDeps.include`
156156
include: [
157-
'@vitejs/test-dep-deep-cjs > use-sync-external-store/shim/index.js',
157+
'@vitejs/test-dep-transitive-cjs > use-sync-external-store/shim/index.js',
158158
],
159159
},
160160
},

pnpm-lock.yaml

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)