Skip to content

Commit 74221f9

Browse files
hi-ogawacodex
andcommitted
test(rsc): pass starter variant as options
Co-authored-by: Codex <noreply@openai.com>
1 parent 10cda62 commit 74221f9

5 files changed

Lines changed: 9 additions & 8 deletions

File tree

packages/plugin-rsc/e2e/browser-mode.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ test.skip(({ browserName }) => browserName === 'webkit')
88

99
test.describe('dev-browser-mode', () => {
1010
const f = useFixture({ root: 'examples/browser-mode', mode: 'dev' })
11-
defineStarterTest(f, 'browser-mode')
11+
defineStarterTest(f, { variant: 'browser-mode' })
1212
defineBrowserModeTest(f)
1313
})
1414

1515
test.describe('build-browser-mode', () => {
1616
const f = useFixture({ root: 'examples/browser-mode', mode: 'build' })
17-
defineStarterTest(f, 'browser-mode')
17+
defineStarterTest(f, { variant: 'browser-mode' })
1818
defineBrowserModeTest(f)
1919
})
2020

packages/plugin-rsc/e2e/browser.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ test.skip(({ browserName }) => browserName === 'webkit')
88

99
test.describe('dev-browser', () => {
1010
const f = useFixture({ root: 'examples/browser', mode: 'dev' })
11-
defineStarterTest(f, 'no-ssr')
11+
defineStarterTest(f, { variant: 'no-ssr' })
1212
})
1313

1414
test.describe('build-browser', () => {
1515
const f = useFixture({ root: 'examples/browser', mode: 'build' })
16-
defineStarterTest(f, 'no-ssr')
16+
defineStarterTest(f, { variant: 'no-ssr' })
1717
})

packages/plugin-rsc/e2e/no-ssr.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import { defineStarterTest } from './starter'
66

77
test.describe('dev-no-ssr', () => {
88
const f = useFixture({ root: 'examples/no-ssr', mode: 'dev' })
9-
defineStarterTest(f, 'no-ssr')
9+
defineStarterTest(f, { variant: 'no-ssr' })
1010
})
1111

1212
test.describe('build-no-ssr', () => {
1313
const f = useFixture({ root: 'examples/no-ssr', mode: 'build' })
14-
defineStarterTest(f, 'no-ssr')
14+
defineStarterTest(f, { variant: 'no-ssr' })
1515

1616
test('no ssr build', () => {
1717
expect(fs.existsSync(path.join(f.root, 'dist/ssr'))).toBe(false)

packages/plugin-rsc/e2e/starter.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ test.describe('dev-production', () => {
6969
env: { NODE_ENV: 'production' },
7070
},
7171
})
72-
defineStarterTest(f, 'dev-production')
72+
defineStarterTest(f, { variant: 'dev-production' })
7373

7474
test('verify production', async ({ page }) => {
7575
await page.goto(f.url())

packages/plugin-rsc/e2e/starter.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ import {
99

1010
export function defineStarterTest(
1111
f: Fixture,
12-
variant?: 'no-ssr' | 'dev-production' | 'browser-mode',
12+
options?: { variant?: 'no-ssr' | 'dev-production' | 'browser-mode' },
1313
) {
14+
const variant = options?.variant
1415
const waitForHydration: typeof waitForHydration_ = (page) =>
1516
waitForHydration_(
1617
page,

0 commit comments

Comments
 (0)