Skip to content

fix(react-swc): don't apply React Refresh wrapper for non JSX files #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnaudBarre wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −11
Open

fix(react-swc): don't apply React Refresh wrapper for non JSX files #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/plugin-react-swc/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Don't apply React Refresh wrapper for non JSX files [#1226](https://github.com/vitejs/vite-plugin-react/pull/1226)

Fixes [#1225](https://github.com/vitejs/vite-plugin-react/issues/1225).

## 4.3.1 (2026-05-14)

### Avoid `esbuild` warnings with Vite 8 [#1195](https://github.com/vitejs/vite-plugin-react/pull/1195)
Expand Down
26 changes: 15 additions & 11 deletions packages/plugin-react-swc/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { join } from 'node:path'
import { exactRegex } from '@rolldown/pluginutils'
import {
type JscTarget,
type Output,
type ParserConfig,
type ReactConfig,
type Options as SWCOptions,
Expand Down Expand Up @@ -197,15 +196,15 @@ const react = (_options?: Options): Plugin[] => {
},
)
if (!result) return
if (!refresh) return result
if (!refresh || !result.jsx) return result.output

const newCode = addRefreshWrapper(
result.code,
result.output.code,
'@vitejs/plugin-react-swc',
id,
options.reactRefreshHost,
)
return { code: newCode ?? result.code, map: result.map }
return { code: newCode ?? result.output.code, map: result.output.map }
},
},
options.plugins || options.useAtYourOwnRisk_mutateSwcOptions
Expand All @@ -219,8 +218,8 @@ const react = (_options?: Options): Plugin[] => {
configResolved(config) {
viteCacheRoot = config.cacheDir
},
transform: (code, _id) =>
transformWithOptions(
async transform(code, _id) {
const result = await transformWithOptions(
_id.split('?')[0],
code,
'esnext',
Expand All @@ -230,7 +229,9 @@ const react = (_options?: Options): Plugin[] => {
runtime: 'automatic',
importSource: options.jsxImportSource,
},
),
)
return result?.output
},
}
: {
name: 'vite:react-swc',
Expand Down Expand Up @@ -293,7 +294,6 @@ const transformWithOptions = async (
: undefined
if (!parser) return

let result: Output
try {
const swcOptions: SWCOptions = {
filename: id,
Expand All @@ -316,7 +316,13 @@ const transformWithOptions = async (
if (options.useAtYourOwnRisk_mutateSwcOptions) {
options.useAtYourOwnRisk_mutateSwcOptions(swcOptions)
}
result = await transform(code, swcOptions)
const output = await transform(code, swcOptions)
return {
output,
jsx:
(parser.syntax === 'typescript' && parser.tsx) ||
(parser.syntax === 'ecmascript' && parser.jsx),
}
} catch (e: any) {
const message: string = e.message
const fileStartIndex = message.indexOf('╭─[')
Expand All @@ -329,8 +335,6 @@ const transformWithOptions = async (
}
throw e
}

return result
}

export default react
Expand Down
Loading