feat: add `@vitejs/plugin-rsc` by hi-ogawa · Pull Request #521 · vitejs/vite-plugin-react

hi-ogawa · 2025-07-03T22:05:57Z

Description

This PR adds @vitejs/plugin-rsc, which is an exact copy of @hiogawa/vite-rsc but simply the package is renamed.

From my own development perspective, having the code in this repo doesn't seem to have any downside at least. Though the code added here is substantially large, its scope is limited to do nothing but enabling "React feature" on Vite, so I think including it here isn't too stretch. Please let me know what you think.

todo

ci
- basic
  - Macos and Windows are considered flaky. Originally on my repo, only ubuntu-latest / chromium CI is required for PR merge.
- refine trigger to reduce run depending on changes
- release setup
rename @hiogawa/vite-rsc to @vitejs/plugin-rsc
chore
- adjust README.md and CHANGELOG.md
- publish first one v0.4.10-alpha.1

todo (follow up)

ci
- canary/experimental channel release setup based on pkg.pr.new chore(rsc): release for react canary/experimental channel [not merge] #524
chore
- update react-router, waku, create-vite to use @vitejs/plugin-rsc
- deprecate @hiogawa/vite-rsc and redirect people to @vitejs/plugin-rsc chore: deprecate @hiogawa/vite-rsc in favor of @vitejs/plugin-rsc hi-ogawa/vite-plugins#1130
- official-ish roadmap Roadmap hi-ogawa/vite-plugins#1108
- contributor guide (basic development tips)
- move relevant issues and prs from vite-rsc issues hi-ogawa/vite-plugins#1127

hi-ogawa · 2025-07-04T02:11:10Z

    "typescript": "^5.8.3",
    "typescript-eslint": "^8.35.1",
-    "vite": "^6.3.3",
+    "vite": "^7.0.1",


Made a PR for Vite 7 bump separately #522

sapphi-red · 2025-07-04T03:36:17Z

+    if (pkgName === 'plugin-rsc') return
+


This change will be removed later on, right? (and the one below)

I'm not sure yet if I switch to ## Unreleased convention. For now, I'll let this skip and use my convention.

I'm fine with that. Instead, could we have a small comment in generateChangelog method so that it's easier to find how the changelog is generated?

I added a comment. Probably the release flow will be to create a PR to just update CHANGELOG.md, then merge it and then run pnpm release on main.

Maybe calling run('pnpm', ['changelog']) here would make it a bit easier? (run function: https://github.com/vitejs/vite/blob/4fc9b6424c27aca8004c368b69991a56264e4fdb/scripts/releaseUtils.ts#L8-L14)
Or the generateChangelog function I added recently can be used if you are fine with a slightly different output.
https://github.com/vitejs/vite/blob/41e83f62b1adb65f5af4c1ec006de1c845437edc/scripts/release.ts#L16-L19

generateChangelog probably works. Let's try that 👍

Co-authored-by: 翠 <green@sapphi.red>

pkg-pr-new · 2025-07-04T04:17:34Z

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-react@521

npm i https://pkg.pr.new/@vitejs/plugin-react-oxc@521

npm i https://pkg.pr.new/@vitejs/plugin-rsc@521

npm i https://pkg.pr.new/@vitejs/plugin-react-swc@521

commit: 3557764

Co-authored-by: 翠 <green@sapphi.red>

Copilot

Pull Request Overview

Adds a new @vitejs/plugin-rsc package—a copy of @hiogawa/vite-rsc renamed and integrated into this monorepo.
Key changes:

Included plugin-rsc in workspace, release scripts, and CI workflow
Added build and test configs (vitest.config.ts, tsdown.config.ts, tsconfig*.json) for plugin-rsc
Introduced all source files under packages/plugin-rsc, including utilities, transforms, core logic, examples, and E2E setup

Reviewed Changes

Copilot reviewed 192 out of 208 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
scripts/release.ts	Added `plugin-rsc` to release pipeline and changelog generation
pnpm-workspace.yaml	Included `packages/plugin-rsc/examples/*` in workspace
packages/plugin-rsc/vitest.config.ts	Vitest setup for `plugin-rsc`
packages/plugin-rsc/tsdown.config.ts	Documentation generator config for `plugin-rsc`
packages/plugin-rsc/tsconfig*.json	TypeScript configuration for `plugin-rsc`
packages/plugin-rsc/src/**	All plugin runtime, transform, and core implementation
packages/plugin-rsc/examples/**	Starter example and configuration files

Comments suppressed due to low confidence (1)

packages/plugin-rsc/src/vite-utils.ts:3

The vite-utils.ts file provides many path and URL helpers but has no accompanying unit tests; adding tests for edge cases (Windows paths, query injection, ID wrapping) will help ensure reliability.

import fs from 'node:fs'

sapphi-red

I think we should remove this line in the future. But that can be done in a separate PR.
https://github.com/hi-ogawa/vite-plugin-react/blob/35577644c85c606015d4c23b866b34386424fb9c/eslint.config.js#L16

hi-ogawa added 12 commits July 3, 2025 18:54

chore: copy vite-rsc

002164a

chore: pnpm

4a99189

chore: build

a089fbc

chore: tsc

79157c3

chore: remove .wrangler

2e6dfd0

chore: gitignore

607c2aa

chore: vite 7

17ffd8b

chore: ci

ebe038b

test: adjust to prettier

5d49b98

ci: pnpm i

6c8e713

chore: pnpm dedupe

9a13353

test: fix TEST_ISOLATED

99418d2

hi-ogawa mentioned this pull request Jul 3, 2025

chore(deps): update Vite 7 #522

Merged

hi-ogawa added 5 commits July 4, 2025 08:53

chore: update vite

55a10fd

ci: remove node 18, add node 24

195fc08

ci: paths filter

dd95606

chore: move @hiogawa/vite-rsc/plugin to @hiogawa/vite-rsc

17aa426

chore: rename @hiogawa/vite-rsc to @vitejs/plugin-rsc

a6ca50c

hi-ogawa added the trigger: preview Trigger pkg.pr.new label Jul 4, 2025

ci: pkgprnew no compact

4f8e2d5

hi-ogawa mentioned this pull request Jul 4, 2025

chore: replace @hiogawa/vite-rsc with @vitejs/plugin-rsc hi-ogawa/waku#17

Merged

chore: cherry-pick v0.4.9

46776a1

hi-ogawa mentioned this pull request Jul 4, 2025

chore: polish readme hi-ogawa/vite-plugins#1128

Merged

hi-ogawa added 3 commits July 4, 2025 11:01

chore: changelog

06aa08d

chore: tweak changelog

f970078

chore: tweak package.json

df15d94

hi-ogawa commented Jul 4, 2025

View reviewed changes

hi-ogawa marked this pull request as ready for review July 4, 2025 02:12

hi-ogawa added 2 commits July 4, 2025 11:19

chore: cherry-pick final readme

9393e5c

chore: tweak release.ts

3dd4fed

hi-ogawa added 2 commits July 4, 2025 11:45

release: plugin-rsc@0.4.10-pre.1

20097fa

chore: fixup readme

8831b0c

hi-ogawa mentioned this pull request Jul 4, 2025

(test publishing @vitejs/plugin-rsc) #523

Closed

hi-ogawa added 2 commits July 4, 2025 12:25

release: plugin-rsc@0.4.10-alpha.0

f33b043

release: plugin-rsc@0.4.10-alpha.1

21d8db8

sapphi-red reviewed Jul 4, 2025

View reviewed changes

hi-ogawa mentioned this pull request Jul 4, 2025

chore(rsc): replace @hiogawa/vite-rsc with @vitejs/plugin-rsc remix-run/react-router#13933

Merged

hi-ogawa and others added 2 commits July 4, 2025 13:16

Apply suggestions from code review

ff3a95c

Co-authored-by: 翠 <green@sapphi.red>

chore: revert pkg.pr.new

f88bdc4

hi-ogawa and others added 2 commits July 4, 2025 13:23

Update .github/workflows/ci-rsc.yml

45441ce

Co-authored-by: 翠 <green@sapphi.red>

chore: comment release.ts

524358c

hi-ogawa mentioned this pull request Jul 4, 2025

feat: use @vitejs/plugin-rsc wakujs/waku#1493

Merged

39 tasks

chore: readme

75dd1dc

This was referenced Jul 4, 2025

feat(create-vite): update rsc template to use @vitejs/plugin-rsc vitejs/vite#20351

Merged

chore: rename vite-rsc to vite-plugin-rsc vitejs/vite-ecosystem-ci#399

Merged

hi-ogawa added 7 commits July 4, 2025 14:59

chore: sort package.json

7e0ba29

Merge branch 'main' into feat-rsc

7cb5e88

chore: use generateChangelog

71a3b93

chore: remove unused

6544b2b

chore: unused

924cfc4

chore: lint

fb48aa6

chore: vite 7.0.2

3557764

hi-ogawa requested a review from Copilot July 4, 2025 07:40

Copilot AI reviewed Jul 4, 2025

View reviewed changes

Comment thread packages/plugin-rsc/src/plugin.ts

Comment thread packages/plugin-rsc/vitest.config.ts

Comment thread scripts/release.ts

sapphi-red approved these changes Jul 4, 2025

View reviewed changes

hi-ogawa mentioned this pull request Jul 4, 2025

chore(rsc): release for react canary/experimental channel [not merge] #524

Closed

hi-ogawa merged commit 0318334 into vitejs:main Jul 6, 2025
21 of 23 checks passed

hi-ogawa deleted the feat-rsc branch July 6, 2025 01:09

hi-ogawa mentioned this pull request Jul 6, 2025

[Tracking] RSC support #531

Closed

21 tasks

Uh oh!

Conversation

hi-ogawa commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

todo

todo (follow up)

Uh oh!

Uh oh!

hi-ogawa Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

sapphi-red Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

sapphi-red Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hi-ogawa commented Jul 3, 2025 •

edited

Loading

sapphi-red Jul 4, 2025 •

edited

Loading

pkg-pr-new Bot commented Jul 4, 2025 •

edited

Loading