Skip to content

fix(rsc): await handler to avoid unhandled rejection #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hi-ogawa merged 1 commit into from
Jul 14, 2025
Merged

fix(rsc): await handler to avoid unhandled rejection #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/plugin-rsc/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,9 @@ export default function vitePluginRsc(
`[vite-rsc] failed to resolve server handler '${source}'`,
)
const mod = await environment.runner.import(resolved.id)
createRequestListener(mod.default)(req, res)
// ensure catching rejected promise
// https://github.com/mjackson/remix-the-web/blob/b5aa2ae24558f5d926af576482caf6e9b35461dc/packages/node-fetch-server/src/lib/request-listener.ts#L87
await createRequestListener(mod.default)(req, res)
} catch (e) {
next(e)
}
Expand Down Expand Up @@ -336,7 +338,7 @@ export default function vitePluginRsc(
return () => {
server.middlewares.use(async (req, res, next) => {
try {
handler(req, res)
await handler(req, res)
} catch (e) {
next(e)
}
Expand Down
Loading