fix(create-vite): error on invalid template in non-interactive mode#22836
Draft
CoderSilicon wants to merge 2 commits into
Draft
fix(create-vite): error on invalid template in non-interactive mode#22836CoderSilicon wants to merge 2 commits into
CoderSilicon wants to merge 2 commits into
Conversation
Member
|
The lint CI is failing |
sapphi-red
marked this pull request as draft
July 2, 2026 02:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when running
create-vitein non-interactive mode (e.g., via a CI/CD script or passing--no-interactive), providing an invalid template name via the--templateflag results in a silent fallback tovanilla-ts. This can mask typos or automation configuration errors, thus creating an unexpected project blueprint without warning.This PR adds an explicit check for invalid user-supplied templates when
interactivemode is disabled. If an invalid template is detected, the Output now logs an error message listing the valid template keys and exits with a status code of1.Related Issues
This was discovered while auditing the non-interactive workflow configuration logic in
packages/create-vite/src/index.ts.Alternatives Explored
Reviewer Notes
The changes are isolated entirely to the template resolution logic within
init().