fix(bundled-dev): preserve import.meta.hot.data across HMR updates

[h-a-n-a]

Description

Closes #23001.

In bundled-dev mode, BundledDevHMRClient.handleModuleCacheRemoval allocated a fresh object, handed it to the dispose callback, and overwrote the module's dataMap entry on every update:

handleModuleCacheRemoval(id: string): void {
  const data = {}
  const disposer = this.disposeMap.get(id)
  if (disposer) {
    disposer(data)
  }
  this.dataMap.set(id, data)
}

This dropped any direct mutation of import.meta.hot.data on every update and never showed the disposer the previous object — the inverse of Vite's documented contract:

The import.meta.hot.data object is persisted across different instances of the same updated module.

Fix

Pass the existing dataMap entry to the disposer and leave it in place, so a re-executed module reuses the same object via the HMRContext constructor (if (!dataMap.has(ownerPath)) dataMap.set(ownerPath, {})). This mirrors the shared HMR client exactly (shared/hmr.ts):

handleModuleCacheRemoval(id: string): void {
  const disposer = this.disposeMap.get(id)
  if (disposer) {
    disposer(this.dataMap.get(id))
  }
}

Test

Adds a data.js module to the hmr-full-bundle-mode playground that increments hot.data.count on each execution and a disposed counter inside its dispose() callback, plus a spec asserting both persist across successive updates (1/0 → 2/1 → 3/2). This covers both required behaviors: direct-mutation persistence and the disposer receiving the existing object.

The test is intentionally ordered before the invalidate test — that test's cleanup restores invalidation-child.js, whose hot.invalidate() propagates to a parent without a shipped factory and forces a full page reload that would otherwise wipe this test's hot.data.

pnpm test-serve hmr-full-bundle-mode passes.

Note

Targets the renovate/rolldown-related-dependencies branch (rolldown 1.2.0 + client-side HMR #22883), since that branch carries the renamed BundledDevHMRClient.

🤖 Generated with Claude Code