mysqlctl: propagate remote shutdown timeout

[mhamza15]

Description

Remote mysqlctl shutdown calls accepted a caller-provided timeout but dropped it when building the gRPC request, causing mysqlctld to fall back to its default shutdown timeout. This carries the timeout through the client interface and serializes it into the shutdown request.

This is a small, isolated bug fix, so I'm suggesting to backport it to v23 and v24.

Related Issue(s)

Closes #20061

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

AI Disclosure

Help from GPT 5.5.

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[Copilot]

Pull request overview

This PR fixes remote mysqlctl shutdown behavior by ensuring the caller-provided shutdown timeout is propagated over the mysqlctld gRPC boundary, instead of being dropped and replaced by mysqlctld’s default.

Changes:

• Extend the MysqlctlClient Shutdown method to accept a shutdownTimeout time.Duration.
• Pass the shutdown timeout through Mysqld.Shutdown when executing remotely via mysqlctld.
• Serialize the timeout into mysqlctlpb.ShutdownRequest using protoutil.DurationToProto.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
go/vt/mysqlctl/mysqld.go	Propagates shutdownTimeout into the remote mysqlctld shutdown call.
go/vt/mysqlctl/mysqlctlclient/interface.go	Updates the client interface to carry shutdownTimeout for remote shutdowns.
go/vt/mysqlctl/grpcmysqlctlclient/client.go	Adds MysqlShutdownTimeout to the gRPC ShutdownRequest payload.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.27%. Comparing base (70c7a72) to head (9603493).
⚠️ Report is 238 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (70c7a72) and HEAD (9603493). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (70c7a72)	HEAD (9603493)
	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #20059       +/-   ##
===========================================
- Coverage   69.67%   52.27%   -17.40%     
===========================================
  Files        1614       46     -1568     
  Lines      216793     7128   -209665     
===========================================
- Hits       151044     3726   -147318     
+ Misses      65749     3402    -62347     

Flag	Coverage Δ
partial	52.27% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mattlord]

LGTM! Can we add some kind of test coverage for it?

[mattlord]

Thanks, @mhamza15 ! ❤️