Skip to content

Update strict task adherence guidelines in AGENTS.md#20069

Merged
mhamza15 merged 1 commit into
mainfrom
mhamza15-patch-1
May 14, 2026
Merged

Update strict task adherence guidelines in AGENTS.md#20069
mhamza15 merged 1 commit into
mainfrom
mhamza15-patch-1

Conversation

@mhamza15
Copy link
Copy Markdown
Collaborator

@mhamza15 mhamza15 commented May 8, 2026

Description

Removed a guideline about not proactively updating documentation.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Removed a guideline about not proactively updating documentation.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 self-assigned this May 8, 2026
Copilot AI review requested due to automatic review settings May 8, 2026 18:13
@github-actions github-actions Bot added this to the v25.0.0 milestone May 8, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 8, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented May 8, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s AI collaboration guidance by removing the “Do NOT proactively update documentation unless explicitly requested” constraint from CLAUDE.md, loosening strict task-adherence rules around documentation updates.

Changes:

  • Removes the prohibition on proactively updating documentation from the “Strict Task Adherence” section in CLAUDE.md.

@mhamza15 mhamza15 added Type: Internal Cleanup Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 8, 2026
@mhamza15 mhamza15 enabled auto-merge (squash) May 8, 2026 18:27
@mhamza15 mhamza15 merged commit 3abf9e9 into main May 14, 2026
128 of 133 checks passed
@mhamza15 mhamza15 deleted the mhamza15-patch-1 branch May 14, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants