Skip to content

[release-23.0] discovery: fix keyspaceState leak for keyspaces missing in localCell (#19993)#20108

Merged
mattlord merged 3 commits into
release-23.0from
backport-19993-to-release-23.0
May 15, 2026
Merged

[release-23.0] discovery: fix keyspaceState leak for keyspaces missing in localCell (#19993)#20108
mattlord merged 3 commits into
release-23.0from
backport-19993-to-release-23.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot Bot commented May 14, 2026

Description

This is a backport of #19993

Copilot AI review requested due to automatic review settings May 14, 2026 18:39
@vitess-bot vitess-bot Bot added Skip CI Skip CI actions from running Merge Conflict labels May 14, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot Bot commented May 14, 2026

Hello @corbantek, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 20108
git reset --hard origin/release-23.0
git cherry-pick -m 1 e3cc8120b6ea3ea8dd2050a0db8d496ef2666c5f

Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vitess-bot vitess-bot Bot requested review from frouioui and timvaillancourt May 14, 2026 18:39
@github-actions github-actions Bot added this to the v23.0.5 milestone May 14, 2026
@mattlord mattlord removed Skip CI Skip CI actions from running Merge Conflict labels May 14, 2026
@mattlord
Fix conflicts
a1185c4 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the backport-19993-to-release-23.0 branch from dccc2c5 to a1185c4 Compare May 14, 2026 19:53
@mattlord mattlord requested a review from mhamza15 May 14, 2026 19:55
@mattlord mattlord marked this pull request as ready for review May 14, 2026 19:55
Copilot AI review requested due to automatic review settings May 14, 2026 19:55
@mattlord mattlord enabled auto-merge (squash) May 14, 2026 19:55
Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread go/vt/discovery/keyspace_events_test.go
Comment thread go/vt/discovery/keyspace_events.go Outdated
Comment thread go/vt/discovery/keyspace_events.go Outdated
@mattlord
Address copilot review comments
3da6abc 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit 1f5b225 into release-23.0 May 15, 2026
167 of 172 checks passed
@mattlord mattlord deleted the backport-19993-to-release-23.0 branch May 15, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mattlord mattlord mattlord approved these changes

@mhamza15 mhamza15 mhamza15 approved these changes

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Cluster management Type: Bug

Projects

None yet

Milestone

v23.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mattlord @mhamza15