Skip to content

chore: treat *.override as *.scope #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
veritem wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: treat *.override as *.scope #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"lint:eslint-docs": "pnpm build && eslint-doc-generator --check",
"lint:js": "eslint",
"release": "bumpp && pnpm build && pnpm publish",
"format": "prettier --check .",
"format": "prettier --check . --write",
"test": "vitest",
"update:chains": "node scripts/chain-permutations.ts",
"update:rules": "node scripts/export-rules.ts",
Expand Down
4 changes: 3 additions & 1 deletion src/rules/expect-expect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ export default createEslintRule<Options, MESSAGE_ID>({
if (
node?.callee?.type === AST_NODE_TYPES.MemberExpression &&
node.callee.property.type === AST_NODE_TYPES.Identifier &&
['skip', 'extend', 'scoped'].includes(node.callee.property.name)
['skip', 'extend', 'scoped', 'override'].includes(
node.callee.property.name,
)
)
return

Expand Down
2 changes: 1 addition & 1 deletion src/rules/prefer-hooks-on-top.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default createEslintRule<Options, MessageIds>({
const vitestFnCall = parseVitestFnCall(node, context)

const hasExemptModifier = vitestFnCall?.members?.some((member) =>
['extend', 'scoped'].includes(getAccessorValue(member)),
['extend', 'scoped', 'override'].includes(getAccessorValue(member)),
)

if (
Expand Down
2 changes: 1 addition & 1 deletion src/rules/valid-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({

// check if extend keyword have been used
const hasExemptModifier = vitestFnCall.members.some((member) =>
['extend', 'scoped'].includes(getAccessorValue(member)),
['extend', 'scoped', 'override'].includes(getAccessorValue(member)),
)
if (hasExemptModifier) {
return
Expand Down
Loading