test: poll for the async wheel event in the user-event fixture#10732
Merged
Conversation
The `scrolls with custom delta values` cases asserted `expect(wheel).toHaveBeenCalledOnce()` synchronously right after dispatching the wheel event, but the browser delivers the event asynchronously — so under load (notably Firefox in CI) the spy was occasionally still uncalled, flaking the `specs/runner.test.ts > user-event` meta-test. Poll for the call like the sibling default-delta cases already do.
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying
expect.pollto try the expect check until it succeeds. We already do the same thing in other places