[Fix] Use latest versions of db services#1157
Conversation
📝 WalkthroughWalkthroughCentralises install script rendering via an installScript() View helper; implements it for MariaDB, MySQL and PostgreSQL; parameterises and hardens DB install/uninstall templates; updates supported service-version lists; and adjusts tests to new MariaDB/MySQL versions. ChangesDatabase installer templates and supported versions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the MariaDB service to support currently installable upstream versions on fresh Ubuntu systems and reduces duplication by switching to a single parameterized install script.
Changes:
- Update MariaDB default/tested version to
10.11and refresh the supported MariaDB version list. - Consolidate version-specific MariaDB install templates into one dynamic
install.blade.phpdriven by the selected version. - Make MariaDB uninstall more tolerant of missing init/systemd service commands.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Feature/ServicesTest.php | Updates service install fixture data to use MariaDB 10.11. |
| tests/Feature/BackupTest.php | Updates backup matrix to use MariaDB 10.11. |
| resources/views/ssh/services/database/mariadb/uninstall.blade.php | Makes service stop calls error-tolerant before removing packages/data. |
| resources/views/ssh/services/database/mariadb/install.blade.php | Parameterizes mariadb_repo_setup to install the selected MariaDB version. |
| resources/views/ssh/services/database/mariadb/install-114.blade.php | Removes version-specific install script (now replaced by dynamic template). |
| resources/views/ssh/services/database/mariadb/install-106.blade.php | Removes version-specific install script (now replaced by dynamic template). |
| resources/views/ssh/services/database/mariadb/install-104.blade.php | Removes version-specific install script (now replaced by dynamic template). |
| resources/views/ssh/services/database/mariadb/install-103.blade.php | Removes version-specific install script (now replaced by dynamic template). |
| app/Services/Database/Mariadb.php | Overrides installScript() to render the new dynamic MariaDB install template with a version variable. |
| app/Services/Database/AbstractDatabase.php | Refactors install flow to call an overridable installScript() hook. |
| app/Providers/ServiceTypeServiceProvider.php | Updates the supported MariaDB versions exposed to the UI/service registration. |
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests