This repository was archived by the owner on Oct 29, 2025. It is now read-only.
vaccination phase pr from Chandan + fixed issues + fixed unit tests#2
Open
thermosento wants to merge 2 commits into
Open
vaccination phase pr from Chandan + fixed issues + fixed unit tests#2thermosento wants to merge 2 commits into
thermosento wants to merge 2 commits into
Conversation
… changed it to ts-data-json - it works in macOS - moved text to language file and fixed typos - fixed layout issue for options in PhaseCard.tsx - fixed all unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
I reviewed Chandan's pull request. I saw some issues, and there were unit test failures. I made some changes to fix those issues and the unit tests. It would be good to include this PR with both Chandan's changes and issue fixes.
This commit:
Chandan's PR: #1
Joey's changes:
Screenshots:
How to test:
Follow the development README to launch the app. Run yarn test to run unit tests.