Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ module.exports = {
"vue/html-self-closing": 0,
"no-unused-vars": 1,
"vue/order-in-components": 0,
"vue/no-deprecated-slot-attribute":0,
"vue/no-deprecated-slot-attribute": 0
}
}
3 changes: 1 addition & 2 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: Node.js Package

on:
push:
tags:
tags:
- v*

jobs:
Expand All @@ -24,7 +24,6 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_API_TOKEN}}


gh-release:
runs-on: ubuntu-latest
permissions: write-all
Expand Down
5 changes: 5 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules
dist
build
*.min.js
package-lock.json
3 changes: 2 additions & 1 deletion .prettierrc

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't singleQuotes the default too?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope default in JS from the most common conventions are double quotes. we agreed on double quotes as well

Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
"bracketSpacing": true,
"bracketSameLine": false,
"arrowParens": "always",
"trailingComma": "none"
"trailingComma": "none",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use always trailing commas. That totally bad in combination with git history. Adding a new element means you change always two lines (the last needs the comma)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree didnt check that one. and not sure why is it on none. probably we need to talk to AK again, as this config was made by him in the utils

"tabWidth": 2
}
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
</div>

### Structure
* **Main components** have to be exported in `./src/main.js`. Main Components should be in folder `./src/components`.
* **Ui Elements** for main components should be in `./src/components/ui` so everyone who contributes can see if there is an element/component already for their use.
* Components should be as small as possible to make the code easier to access and understand, thats why the directory structure has importance.
* Every logic/function according to articles/items/cart or anything else should be in the `cartStore` in `./src/stores/cart.js` - reason is as follows - all components get their data with so called props which are not "reactive" by nature. We want to trigger a rerender if we change/add/edit... items thats why anything according to that should be in the cartStore. Read the cartStore carefully and use the already existing states to grant a clean rerender/reactive process. The props all get updated as soon as the main states get updated in the `cartStore` -> rerender --> profit...

- **Main components** have to be exported in `./src/main.js`. Main Components should be in folder `./src/components`.
- **Ui Elements** for main components should be in `./src/components/ui` so everyone who contributes can see if there is an element/component already for their use.
- Components should be as small as possible to make the code easier to access and understand, thats why the directory structure has importance.
- Every logic/function according to articles/items/cart or anything else should be in the `cartStore` in `./src/stores/cart.js` - reason is as follows - all components get their data with so called props which are not "reactive" by nature. We want to trigger a rerender if we change/add/edit... items thats why anything according to that should be in the cartStore. Read the cartStore carefully and use the already existing states to grant a clean rerender/reactive process. The props all get updated as soon as the main states get updated in the `cartStore` -> rerender --> profit...

Try to understand this structure and adopt it with new components for easy implementation without much effort.

Expand Down
140 changes: 80 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 13 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,25 @@
"main": "src/main.js",
"scripts": {
"build": "vite build",
"watch": "vite build --watch"
"watch": "vite build --watch",
"format": "prettier --write .",
"format:check": "prettier --check ."
},
"dependencies": {
"@viur/ignite": "^5.1.2",
"@viur/shoelace": "^1.0.10-v2.20.0",
"@viur/vue-utils": "^3.1.4",
"@vueuse/core": "^13.1.0",
"@viur/vue-utils": "^3.1.5",
"@vueuse/core": "^13.5.0",
"pinia": "^2.3.1",
"vue": "^3.5.13",
"vue-i18n": "^11.1.3",
"vue-router": "^4.5.0"
"vue": "^3.5.17",
"vue-i18n": "^11.1.10",
"vue-router": "^4.5.1"
},
"devDependencies": {
"@vitejs/plugin-vue": "^5.2.3",
"postcss-custom-media": "^11.0.5",
"postcss-nesting": "^13.0.1",
"prettier": "^3.5.3",
"vite": "^6.2.6"
"@vitejs/plugin-vue": "^6.0.0",
"postcss-custom-media": "^11.0.6",
"postcss-nesting": "^13.0.2",
"prettier": "^3.6.2",
"vite": "^7.0.5"
}
}
Loading
Loading