feat: Inherit RefSkel from the source Skeleton#1617
Draft
sveneberth wants to merge 2 commits into
Draft
Conversation
This make `@property`s working properly and allows type checks.
sveneberth
added
the
bug(fix)
phorward
added a commit
that referenced
this pull request
Feb 13, 2026
…elongs to a `RefSkel` + reset `renderPreparation` (#1623) - A `@property` member can now be accessed on a `SkeletonInstance` belongs to a `RefSkel`. Before loading `class_value` the type of `skeletonCls` will be evaluated. - Before calling the compute or `@property` function with the help of `without_render_preparation`, it will be ensured that the `SkeletonInstance` is called without any `renderPreparation`. This avoids for example providing the key string-encoding instead of the `db.Key` instance. - Introduce `without_render_preparation` (known from [viur-toolkit](https://github.com/viur-framework/viur-toolkit/blob/1d95b1a8ee5fb40e0847094821ff6e424891376d/src/viur/toolkit/viur.py#L38-L65)) - Introduce `is_skeletoninstance_of` for handy checks (instead of this https://github.com/viur-framework/viur-shop/blob/2a55ef1aa2fdb00d6a6af3985cfe151c5d6aedb6/src/viur/shop/types/dc_scope.py#L243-L257) --- Fixes #1622 Alternative solution to #1617 Also replaces #1619 --------- Co-authored-by: Jan Max Meyer <jmm@phorward.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make
@propertys working properly and allows type checks.Currently checks like this this https://github.com/viur-framework/viur-shop/blob/2a55ef1aa2fdb00d6a6af3985cfe151c5d6aedb6/src/viur/shop/types/dc_scope.py#L243-L257
would be more easy.
This fixes #1622
Warning: It seems to work, but at the moment, I don't want to rule out any ViUR surprises.