Commit 01c2f11
committed
refactor(config): address post-approval review cleanups
Address three follow-up review comments after the initial approvals:
- xxo1shine (Args.java:345): drop the unused `config` parameter from
`applyRateLimiterConfig`; it was a leftover from the pre-refactor path
that used `getRateLimiterFromConfig(config)`.
- 317787106 (NodeConfig.java:387): remove the `disconnectNumberFactor`
bean field and its reference.conf default — no code in this repo or
in develop reads it; purely synthetic dead weight introduced by this
PR. The other 7 keys listed by the reviewer are kept (actively used,
legacy aliases, or public API surface); see review reply for per-key
rationale.
- 317787106 (Args.java:1146): switch `== null` to
`StringUtils.isEmpty(...)` on the `externalIp()` fallback guard. Not
a behaviour change in the current architecture (no CLI flag or other
code writes `PARAMETER.nodeExternalIp` before this point, so it can
only be null here), but makes the intent consistent with the
`isEmpty` checks already used on lines 1145 and 1149.1 parent 998779e commit 01c2f11
3 files changed
Lines changed: 3 additions & 5 deletions
File tree
- common/src/main
- java/org/tron/core/config/args
- resources
- framework/src/main/java/org/tron/core/config/args
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | 238 | | |
240 | 239 | | |
241 | 240 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
| 345 | + | |
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
| |||
779 | 779 | | |
780 | 780 | | |
781 | 781 | | |
782 | | - | |
| 782 | + | |
783 | 783 | | |
784 | 784 | | |
785 | 785 | | |
| |||
1143 | 1143 | | |
1144 | 1144 | | |
1145 | 1145 | | |
1146 | | - | |
| 1146 | + | |
1147 | 1147 | | |
1148 | 1148 | | |
1149 | 1149 | | |
| |||
0 commit comments