fix(config): remove sentinel conversions, use reference.conf defaults

Remove incorrect if(==sentinel)→default conversions from Args.java
that were added during refactoring. These break user configs that
explicitly set the sentinel value (e.g. minEffectiveConnection=0
in system-test). Now reference.conf provides the actual default
values directly:

- rpcThreadNum: sentinel 16→0 (0 means auto-detect)
- maxConcurrentCallsPerConnection: 100→2147483647 (Integer.MAX_VALUE)
- flowControlWindow: 0→1048576 (1MB, gRPC default)
- maxMessageSize: 0→4194304 (4MB, gRPC default)
- maxHeaderListSize: 0→8192 (gRPC default)
- minEffectiveConnection: remove if(==0)→1 conversion entirely

Author: vividctrlalt

common/src/main/resources/reference.conf

@@ -268,27 +268,27 @@ node {
     PBFTEnable = true
     PBFTPort = 50071
 
-    # Number of gRPC threads, default availableProcessors / 2
-    thread = 16
+    # Number of gRPC threads, 0 = auto (availableProcessors / 2)
+    thread = 0
 
     # Maximum concurrent calls per incoming connection
-    # 100 triggers Args conversion to Integer.MAX_VALUE (no limit)
-    maxConcurrentCallsPerConnection = 100
+    # No limit on concurrent calls per connection
+    maxConcurrentCallsPerConnection = 2147483647
 
-    # 0 = use gRPC default (1MB)
-    flowControlWindow = 0
+    # HTTP/2 flow control window (bytes), default 1MB
+    flowControlWindow = 1048576
 
     # Connection idle timeout (ms). No limit by default.
     maxConnectionIdleInMillis = 9223372036854775807
 
     # Connection max age (ms). No limit by default.
     maxConnectionAgeInMillis = 9223372036854775807
 
-    # 0 = use gRPC default (4MB)
-    maxMessageSize = 0
+    # Maximum message size (bytes), default 4MB
+    maxMessageSize = 4194304
 
-    # 0 = use gRPC default (8192)
-    maxHeaderListSize = 0
+    # Maximum header list size (bytes), default 8192
+    maxHeaderListSize = 8192
 
     # RST_STREAM frames allowed per connection per period, 0 = no limit
     maxRstStream = 0

framework/src/main/java/org/tron/core/config/args/Args.java

@@ -543,36 +543,19 @@ private static void applyNodeConfig(NodeConfig nc) {
     PARAMETER.rpcOnSolidityPort = rpc.getSolidityPort();
     PARAMETER.rpcOnPBFTPort = rpc.getPBFTPort();
     PARAMETER.rpcThreadNum = rpc.getThread();
-    if (PARAMETER.rpcThreadNum == 16) {
-      // default from bean — apply dynamic default: (CPUs + 1) / 2
+    if (PARAMETER.rpcThreadNum == 0) {
       PARAMETER.rpcThreadNum = (Runtime.getRuntime().availableProcessors() + 1) / 2;
     }
     PARAMETER.maxConcurrentCallsPerConnection = rpc.getMaxConcurrentCallsPerConnection();
-    if (PARAMETER.maxConcurrentCallsPerConnection == 100) {
-      // bean default 100 — original code used Integer.MAX_VALUE as default
-      PARAMETER.maxConcurrentCallsPerConnection = Integer.MAX_VALUE;
-    }
     PARAMETER.flowControlWindow = rpc.getFlowControlWindow();
-    if (PARAMETER.flowControlWindow == 0) {
-      PARAMETER.flowControlWindow = NettyServerBuilder.DEFAULT_FLOW_CONTROL_WINDOW;
-    }
     PARAMETER.rpcMaxRstStream = rpc.getMaxRstStream();
     PARAMETER.rpcSecondsPerWindow = rpc.getSecondsPerWindow();
     PARAMETER.maxConnectionIdleInMillis = rpc.getMaxConnectionIdleInMillis();
     PARAMETER.maxConnectionAgeInMillis = rpc.getMaxConnectionAgeInMillis();
     PARAMETER.maxMessageSize = rpc.getMaxMessageSize();
-    if (PARAMETER.maxMessageSize == 0) {
-      PARAMETER.maxMessageSize = GrpcUtil.DEFAULT_MAX_MESSAGE_SIZE;
-    }
     PARAMETER.maxHeaderListSize = rpc.getMaxHeaderListSize();
-    if (PARAMETER.maxHeaderListSize == 0) {
-      PARAMETER.maxHeaderListSize = GrpcUtil.DEFAULT_MAX_HEADER_LIST_SIZE;
-    }
     PARAMETER.isRpcReflectionServiceEnable = rpc.isReflectionService();
     PARAMETER.minEffectiveConnection = rpc.getMinEffectiveConnection();
-    if (PARAMETER.minEffectiveConnection == 0) {
-      PARAMETER.minEffectiveConnection = 1;
-    }
     PARAMETER.trxCacheEnable = rpc.isTrxCacheEnable();
 
     // ---- HTTP sub-bean ----