Added web test generation skill for claude#295
Conversation
GrimA9e
requested review from
ikalinin1,
valfirst and
vkepin
and removed request for
a team
📝 WalkthroughWalkthroughThis PR adds a new Claude skill for VIVIDUS web test generation, reduces the existing GitHub skill to a shared-guidelines pointer, and adds a centralized markdown guide covering test execution, step mapping, story authoring rules, and output formatting. ChangesVIVIDUS Web Test Generation Skill Documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shared-ai-guidelines/generate-vividus-web-tests-guidelines.md`:
- Around line 95-97: The Context7 optional lookup in the VIVIDUS guidelines is
currently unreachable for the new Claude skill because the entrypoint does not
expose any Context7 MCP tool. Update the shared guide around the Context7 branch
to either remove this optional step or align the skill metadata so the
referenced `context7_resolve-library-id` and `context7_query-docs` actions are
actually available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5146b849-9738-4b78-936a-18dda6999822
📒 Files selected for processing (3)
.claude/skills/generate-vividus-web-tests/SKILL.md.github/skills/generate-vividus-web-tests/SKILL.mdshared-ai-guidelines/generate-vividus-web-tests-guidelines.md
GrimA9e
force-pushed
the
claude-web-test-skill
branch
from
24fa5ad to
10cb953
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shared-ai-guidelines/generate-vividus-web-tests-guidelines.md`:
- Line 1: The document starts with an H2 instead of a top-level heading, which
triggers the markdownlint rule. Update the opening heading in
generate-vividus-web-tests-guidelines.md from the current Process Overview
section to an H1 so the guide has a proper top-level title and stays
lint-compliant.
- Around line 113-114: Remove the instruction to create new composite steps from
the guidelines and replace it with wording that tells the agent to reuse
existing composite steps only; the current “Composite Steps” guidance conflicts
with the .story-only constraint and may lead to unsupported file creation.
Update the relevant guidance text in the markdown so it references only existing
composite steps and keep any new composite-step authoring out of this workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a3665c05-208e-4a57-9ab9-ddf66a49b585
📒 Files selected for processing (3)
.claude/skills/generate-vividus-web-tests/SKILL.md.github/skills/generate-vividus-web-tests/SKILL.mdshared-ai-guidelines/generate-vividus-web-tests-guidelines.md
| @@ -0,0 +1,278 @@ | |||
| ## Process Overview | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a top-level heading.
The file starts with ##, which trips the markdownlint rule already reported here. Switching the opener to an H1 keeps the guide compliant and avoids noisy lint failures.
Suggested fix
-## Process Overview
+# Process Overview📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Process Overview | |
| # Process Overview |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@shared-ai-guidelines/generate-vividus-web-tests-guidelines.md` at line 1, The
document starts with an H2 instead of a top-level heading, which triggers the
markdownlint rule. Update the opening heading in
generate-vividus-web-tests-guidelines.md from the current Process Overview
section to an H1 so the guide has a proper top-level title and stays
lint-compliant.
Source: Linters/SAST tools
| 4. **Composite Steps:** Create new composite steps for repeated action patterns. | ||
| 5. **Contextual Steps:** When using parent element context, ensure child locators are relative. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Remove the composite-step creation instruction.
This conflicts with Step 5’s “only the .story file” rule and can prompt the agent to invent unsupported files. Rephrase it to reuse existing composite steps only, or move composite-step authoring to a separate workflow.
Suggested fix
-4. **Composite Steps:** Create new composite steps for repeated action patterns.
+4. **Composite Steps:** Reuse existing composite steps for repeated action patterns.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 4. **Composite Steps:** Create new composite steps for repeated action patterns. | |
| 5. **Contextual Steps:** When using parent element context, ensure child locators are relative. | |
| 4. **Composite Steps:** Reuse existing composite steps for repeated action patterns. | |
| 5. **Contextual Steps:** When using parent element context, ensure child locators are relative. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@shared-ai-guidelines/generate-vividus-web-tests-guidelines.md` around lines
113 - 114, Remove the instruction to create new composite steps from the
guidelines and replace it with wording that tells the agent to reuse existing
composite steps only; the current “Composite Steps” guidance conflicts with the
.story-only constraint and may lead to unsupported file creation. Update the
relevant guidance text in the markdown so it references only existing composite
steps and keep any new composite-step authoring out of this workflow.
1 participant
Summary by CodeRabbit