Added gradle task to generate web test skill from shared guidelines#296
Added gradle task to generate web test skill from shared guidelines#296GrimA9e wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughAdds a new Gradle-based pipeline (skills.gradle) driven by a JSON manifest (skills.json) to generate per-target SKILL.md files from a shared guideline markdown source, registers a generateSkills task, applies the script from build.gradle, and removes frontmatter metadata from the guideline source file. ChangesSkill generation pipeline
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills.gradle`:
- Around line 66-72: The generateSkills task in the
tasks.register('generateSkills') block declares inputs but no outputs, so Gradle
cannot treat it as up-to-date. Update the task definition to declare the
generated skill files or output directory as outputs, using the same
manifest-driven target output path used by processSkills and target.outDir, so
Gradle can skip reruns when nothing has changed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0da22fe2-4feb-4bb7-8a3b-0f58da193354
📒 Files selected for processing (4)
build.gradleshared-ai-guidelines/generate-vividus-web-tests-guidelines.mdshared-ai-guidelines/skills.jsonskills.gradle
💤 Files with no reviewable changes (1)
- shared-ai-guidelines/generate-vividus-web-tests-guidelines.md
| tasks.register('generateSkills') { | ||
| group = 'documentation' | ||
| description = 'Generate per-tool skill files from shared-ai-guidelines. Use -Ptarget=claude|copilot to limit; omit for all.' | ||
| inputs.file skillsManifestFile | ||
| inputs.dir file("${rootDir}/shared-ai-guidelines") | ||
| doLast { processSkills(project.findProperty('target') as String) } | ||
| } |
There was a problem hiding this comment.
🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win
Task declares inputs but no outputs, disabling incremental build support.
generateSkills registers inputs.file/inputs.dir but no outputs.dir/outputs.files. Without declared outputs, Gradle can't perform UP-TO-DATE checks for this task, so it always executes even when nothing changed. Since output paths are derivable from the manifest (target.outDir per target), consider declaring them for better build performance.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills.gradle` around lines 66 - 72, The generateSkills task in the
tasks.register('generateSkills') block declares inputs but no outputs, so Gradle
cannot treat it as up-to-date. Update the task definition to declare the
generated skill files or output directory as outputs, using the same
manifest-driven target output path used by processSkills and target.outDir, so
Gradle can skip reruns when nothing has changed.
Summary by CodeRabbit