Skip to content

Added gradle task to generate web test skill from shared guidelines#296

Closed
GrimA9e wants to merge 1 commit into
vividus-framework:mainfrom
GrimA9e:web-skill-generator
Closed

Added gradle task to generate web test skill from shared guidelines#296
GrimA9e wants to merge 1 commit into
vividus-framework:mainfrom
GrimA9e:web-skill-generator

Conversation

@GrimA9e

@GrimA9e GrimA9e commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added support for generating tool-specific skill guides from shared documentation, including configurable output for different targets.
  • Documentation
    • Simplified the shared guidance source by removing embedded metadata and keeping the main step-by-step content intact.

@GrimA9e GrimA9e requested a review from a team as a code owner July 2, 2026 23:44
@GrimA9e GrimA9e requested review from uarlouski, valfirst and vkepin and removed request for a team July 2, 2026 23:44
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new Gradle-based pipeline (skills.gradle) driven by a JSON manifest (skills.json) to generate per-target SKILL.md files from a shared guideline markdown source, registers a generateSkills task, applies the script from build.gradle, and removes frontmatter metadata from the guideline source file.

Changes

Skill generation pipeline

Layer / File(s) Summary
Skills manifest and guideline source
shared-ai-guidelines/skills.json, shared-ai-guidelines/generate-vividus-web-tests-guidelines.md
Adds a manifest defining shared directory, per-target output dirs (claude, copilot), and skill metadata; removes YAML frontmatter block from the guideline markdown.
Render and write SKILL.md logic
skills.gradle
Adds renderSkill closure to load guideline content, apply target-specific replacements, and build YAML frontmatter; adds processSkills closure to parse the manifest, filter targets, render skills, and write output files.
Gradle task registration and wiring
skills.gradle, build.gradle
Registers generateSkills task with documentation grouping and declared inputs, invoking processSkills via -Ptarget; applies skills.gradle from build.gradle.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a Gradle task to generate the web test skill from shared guidelines.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills.gradle`:
- Around line 66-72: The generateSkills task in the
tasks.register('generateSkills') block declares inputs but no outputs, so Gradle
cannot treat it as up-to-date. Update the task definition to declare the
generated skill files or output directory as outputs, using the same
manifest-driven target output path used by processSkills and target.outDir, so
Gradle can skip reruns when nothing has changed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0da22fe2-4feb-4bb7-8a3b-0f58da193354

📥 Commits

Reviewing files that changed from the base of the PR and between 021154a and c0d4c7c.

📒 Files selected for processing (4)
  • build.gradle
  • shared-ai-guidelines/generate-vividus-web-tests-guidelines.md
  • shared-ai-guidelines/skills.json
  • skills.gradle
💤 Files with no reviewable changes (1)
  • shared-ai-guidelines/generate-vividus-web-tests-guidelines.md

Comment thread skills.gradle
Comment on lines +66 to +72
tasks.register('generateSkills') {
group = 'documentation'
description = 'Generate per-tool skill files from shared-ai-guidelines. Use -Ptarget=claude|copilot to limit; omit for all.'
inputs.file skillsManifestFile
inputs.dir file("${rootDir}/shared-ai-guidelines")
doLast { processSkills(project.findProperty('target') as String) }
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Task declares inputs but no outputs, disabling incremental build support.

generateSkills registers inputs.file/inputs.dir but no outputs.dir/outputs.files. Without declared outputs, Gradle can't perform UP-TO-DATE checks for this task, so it always executes even when nothing changed. Since output paths are derivable from the manifest (target.outDir per target), consider declaring them for better build performance.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills.gradle` around lines 66 - 72, The generateSkills task in the
tasks.register('generateSkills') block declares inputs but no outputs, so Gradle
cannot treat it as up-to-date. Update the task definition to declare the
generated skill files or output directory as outputs, using the same
manifest-driven target output path used by processSkills and target.outDir, so
Gradle can skip reruns when nothing has changed.

@GrimA9e GrimA9e closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant