-
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: Show pagination progress during PDF build #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
u1f992
wants to merge
10
commits into
main
Choose a base branch
from
feat/pdf-build-pagination-progress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−50
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
577b399
feat: Show pagination progress during PDF build
u1f992 2471cce
fix: Ignore unparsable href in pagination progress
u1f992 af9a305
fix: Show progress entry paths as plain text to avoid spinner corruption
u1f992 b69f2fb
chore: Add changeset for the pagination progress feature
u1f992 a1a4794
fix: Restore hyperlinked progress paths with yocto-spinner 1.2.1
u1f992 35a719b
feat: Show the pagination progress ETA as a live hh:mm:ss countdown
u1f992 14a6e76
fix: Remove the ETA; the live countdown shows it constantly drifts
u1f992 c8d777b
fix: Don't emit a spurious 0% progress line for the first document
u1f992 26325cb
fix: Don't checkpoint 'Building pages' until the first document arrives
u1f992 a66e12b
fix: Attribute pagination progress to contents and cover entries, not…
u1f992 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@vivliostyle/cli': minor | ||
| --- | ||
|
|
||
| Show pagination progress (current document, page count, and percentage) during PDF builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.