Misc updates#1202
Open
curran wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes small cleanup updates in the LLM streaming server code, primarily improving how diff metadata is attached to AI chat messages to avoid relying on “last message” assumptions.
Changes:
- Update
addDiffToAIMessageto optionally target a specific AI message viamessageId, with a safer fallback that searches for the most recent assistant message. - Remove stray blank lines in the LLM streaming implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/llm-streaming-server/llmStreaming.ts |
Removes unnecessary blank lines (formatting cleanup). |
src/llm-streaming-server/chatOperations.ts |
Improves diff attachment logic by supporting explicit message targeting and safer assistant-message lookup. |
Comment on lines
+313
to
+323
| if (messageId) { | ||
| targetMessageIndex = messages.findIndex( | ||
| (msg) => msg.id === messageId, | ||
| ); | ||
| if (targetMessageIndex === -1) { | ||
| console.warn( | ||
| `AI message with id ${messageId} not found in chat ${chatId}`, | ||
| ); | ||
| return; | ||
| } | ||
| } else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.