♻️ Tighten visual context dogfood paths

Simplify the Swift SDK E2E handoff cleanup and make agent context evidence classification resilient to status-only failed comparisons.

Author: Robdel12

clients/swift/scripts/run-e2e.js

@@ -27,6 +27,36 @@ let swiftTestCommand = [
   'VizzlyE2ETests',
 ].join(' ');
 
+function cleanupAndExit(code = 1) {
+  rmSync(tempDir, { recursive: true, force: true });
+  process.exit(code);
+}
+
+function printLocalContext() {
+  let contextResult = spawnSync(
+    process.execPath,
+    [cliPath, 'context', 'build', 'current', '--source', 'local', '--agent'],
+    {
+      cwd: tempDir,
+      encoding: 'utf8',
+      env: {
+        ...process.env,
+        VIZZLY_HOME: vizzlyHome,
+      },
+    }
+  );
+
+  if (contextResult.stdout) {
+    process.stdout.write(contextResult.stdout);
+  }
+
+  if (contextResult.stderr) {
+    process.stderr.write(contextResult.stderr);
+  }
+
+  return contextResult.status ?? 1;
+}
+
 let child = spawn(
   process.execPath,
   [cliPath, 'tdd', 'run', swiftTestCommand, '--no-color'],
@@ -42,40 +72,15 @@ let child = spawn(
 );
 
 child.on('exit', code => {
-  if (code === 0) {
-    let contextResult = spawnSync(
-      process.execPath,
-      [cliPath, 'context', 'build', 'current', '--source', 'local', '--agent'],
-      {
-        cwd: tempDir,
-        encoding: 'utf8',
-        env: {
-          ...process.env,
-          VIZZLY_HOME: vizzlyHome,
-        },
-      }
-    );
-
-    if (contextResult.stdout) {
-      process.stdout.write(contextResult.stdout);
-    }
-
-    if (contextResult.stderr) {
-      process.stderr.write(contextResult.stderr);
-    }
-
-    if (contextResult.status !== 0) {
-      rmSync(tempDir, { recursive: true, force: true });
-      process.exit(contextResult.status ?? 1);
-    }
+  if (code !== 0) {
+    cleanupAndExit(code ?? 1);
   }
 
-  rmSync(tempDir, { recursive: true, force: true });
-  process.exit(code ?? 1);
+  let contextStatus = printLocalContext();
+  cleanupAndExit(contextStatus);
 });
 
 child.on('error', error => {
-  rmSync(tempDir, { recursive: true, force: true });
   console.error(error);
-  process.exit(1);
+  cleanupAndExit(1);
 });

src/commands/context.js

@@ -247,6 +247,16 @@ function getComparisonDisplayState(comparison = {}) {
   return comparison.result || comparison.status || 'unknown';
 }
 
+function isChangedComparison(comparison = {}) {
+  return ['changed', 'failed', 'pending'].includes(
+    getComparisonDisplayState(comparison)
+  );
+}
+
+function isNewComparison(comparison = {}) {
+  return getComparisonDisplayState(comparison) === 'new';
+}
+
 function getComparisonName(comparison = {}) {
   return (
     comparison.screenshot_name ||
@@ -421,12 +431,8 @@ function displayBuildContext(output, context) {
 
 function formatAgentBuildContext(context) {
   let comparisons = context.comparisons || [];
-  let changed = comparisons.filter(
-    comparison => getComparisonDisplayState(comparison) === 'changed'
-  );
-  let fresh = comparisons.filter(
-    comparison => getComparisonDisplayState(comparison) === 'new'
-  );
+  let changed = comparisons.filter(isChangedComparison);
+  let fresh = comparisons.filter(isNewComparison);
   let needsReview = comparisons.filter(comparison => comparison.needs_review);
   let baseline = context.baseline?.selected;
   let lines = [

tests/commands/context.test.js

@@ -455,6 +455,55 @@ describe('commands/context', () => {
       assert.ok(agentOutput.includes('Dashboard: identical'));
       assert.ok(agentOutput.includes('Settings: identical'));
     });
+
+    it('includes status-only failed comparisons in agent evidence', async () => {
+      let output = createMockOutput();
+
+      await contextBuildCommand(
+        'build-1',
+        { agent: true },
+        {},
+        {
+          loadConfig: async () => ({
+            apiKey: 'token',
+            apiUrl: 'https://api.test',
+          }),
+          createApiClient: () => ({}),
+          getBuildContext: async () => ({
+            resource: 'build_context',
+            scope: {
+              organization: { slug: 'acme' },
+              project: { slug: 'web' },
+            },
+            build: {
+              id: 'build-1',
+              name: 'build-1',
+              status: 'completed',
+            },
+            status: { needs_review: true, pending_comparisons: 1 },
+            comparisons: [
+              {
+                screenshot_name: 'Checkout',
+                status: 'failed',
+                needs_review: true,
+                diff_percentage: 0.8,
+              },
+            ],
+          }),
+          output,
+          exit: () => {},
+        }
+      );
+
+      let agentOutput = output.calls
+        .filter(call => call.method === 'print')
+        .map(call => call.args[0])
+        .join('\n');
+
+      assert.ok(agentOutput.includes('## Evidence To Inspect'));
+      assert.ok(agentOutput.includes('Checkout: failed'));
+      assert.ok(agentOutput.includes('0.8% diff'));
+    });
   });
 
   describe('contextComparisonCommand', () => {