♻️ Finish CLI audit cleanup stack

Why: land the remaining CLI audit stack as the final integration PR after preserving the smaller review units.\n\nWhat changed:\n- Integrated server events, uploader boundaries, TDD/status plumbing, Storybook client cleanup, and static-site client cleanup.\n- Removed stale compatibility paths and dead runtime/service code.\n- Added focused outcome coverage around commands, server routes, uploader behavior, and client packages.\n\nVerification:\n- npm run lint\n- npm run build\n- GitHub CI Status passed on PR #265

Author: Robdel12

clients/ember/bin/vizzly-testem-launcher.js

@@ -103,7 +103,10 @@ async function main() {
 
     // 2. Determine failOnDiff: env var > server.json > default (false)
     let failOnDiff = false;
-    if (process.env.VIZZLY_FAIL_ON_DIFF === 'true' || process.env.VIZZLY_FAIL_ON_DIFF === '1') {
+    if (
+      process.env.VIZZLY_FAIL_ON_DIFF === 'true' ||
+      process.env.VIZZLY_FAIL_ON_DIFF === '1'
+    ) {
       failOnDiff = true;
     } else {
       let serverInfo = getServerInfo();

clients/ember/src/launcher/screenshot-server.js

@@ -181,7 +181,9 @@ function httpPost(url, data) {
 
         if (res.statusCode >= 400) {
           reject(
-            new Error(`Vizzly server error: ${res.statusCode} - ${responseBody}`)
+            new Error(
+              `Vizzly server error: ${res.statusCode} - ${responseBody}`
+            )
           );
           return;
         }

clients/ember/src/test-support/index.js

@@ -161,8 +161,10 @@ function prepareTestingContainer(width = 1280, height = 720, fullPage = false) {
  * @returns {boolean}
  */
 function shouldFailOnDiff() {
-  return window.__VIZZLY_FAIL_ON_DIFF__ === true ||
-         window.__VIZZLY_FAIL_ON_DIFF__ === 'true';
+  return (
+    window.__VIZZLY_FAIL_ON_DIFF__ === true ||
+    window.__VIZZLY_FAIL_ON_DIFF__ === 'true'
+  );
 }
 
 /**
@@ -285,7 +287,9 @@ export async function vizzlyScreenshot(name, options = {}) {
       // Check if this is a "no server" error - gracefully skip instead of failing
       // This allows tests to pass when Vizzly isn't running (like Percy behavior)
       if (errorText.includes('No Vizzly server found')) {
-        console.warn('[vizzly] Vizzly server not running. Skipping visual screenshot.');
+        console.warn(
+          '[vizzly] Vizzly server not running. Skipping visual screenshot.'
+        );
         return { status: 'skipped', reason: 'no-server' };
       }
 
@@ -302,12 +306,14 @@ export async function vizzlyScreenshot(name, options = {}) {
       if (shouldFail) {
         throw new VizzlyDiffError(
           `Visual difference detected for '${name}' (${result.diffPercentage?.toFixed(2)}% diff). ` +
-          `View diff in Vizzly dashboard.`
+            `View diff in Vizzly dashboard.`
         );
       }
 
       // Log warning but don't fail
-      console.warn(`[vizzly] Visual difference detected for '${name}'. View diff in Vizzly dashboard.`);
+      console.warn(
+        `[vizzly] Visual difference detected for '${name}'. View diff in Vizzly dashboard.`
+      );
     }
 
     return result;
@@ -320,7 +326,9 @@ export async function vizzlyScreenshot(name, options = {}) {
     // Log connection errors only once to avoid spam
     if (!hasLoggedConnectionError) {
       hasLoggedConnectionError = true;
-      console.warn(`[vizzly] Screenshots skipped - server not available. Run 'vizzly tdd start' to enable.`);
+      console.warn(
+        `[vizzly] Screenshots skipped - server not available. Run 'vizzly tdd start' to enable.`
+      );
     }
     return { status: 'skipped', reason: 'error', error: error.message };
   } finally {

clients/ember/tests/unit/screenshot-server.test.js

@@ -231,7 +231,10 @@ describe('screenshot-server', () => {
         // (unless there's a server.json in a parent directory)
         if (info !== null) {
           assert.ok(typeof info.url === 'string', 'should have url');
-          assert.ok(typeof info.failOnDiff === 'boolean', 'should have failOnDiff');
+          assert.ok(
+            typeof info.failOnDiff === 'boolean',
+            'should have failOnDiff'
+          );
         }
       } finally {
         process.chdir(originalCwd);
@@ -260,8 +263,16 @@ describe('screenshot-server', () => {
         let info = getServerInfo();
 
         assert.ok(info !== null, 'should find server.json');
-        assert.strictEqual(info.url, 'http://localhost:47392', 'should have correct url');
-        assert.strictEqual(info.failOnDiff, true, 'should read failOnDiff as true');
+        assert.strictEqual(
+          info.url,
+          'http://localhost:47392',
+          'should have correct url'
+        );
+        assert.strictEqual(
+          info.failOnDiff,
+          true,
+          'should read failOnDiff as true'
+        );
       } finally {
         process.chdir(originalCwd);
       }
@@ -287,8 +298,16 @@ describe('screenshot-server', () => {
         let info = getServerInfo();
 
         assert.ok(info !== null, 'should find server.json');
-        assert.strictEqual(info.url, 'http://localhost:47393', 'should have correct url');
-        assert.strictEqual(info.failOnDiff, false, 'should default failOnDiff to false');
+        assert.strictEqual(
+          info.url,
+          'http://localhost:47393',
+          'should have correct url'
+        );
+        assert.strictEqual(
+          info.failOnDiff,
+          false,
+          'should default failOnDiff to false'
+        );
       } finally {
         process.chdir(originalCwd);
       }

clients/ember/tests/unit/testem-config.test.js

@@ -155,7 +155,10 @@ describe('testem-config', () => {
 
       configure({}, {});
 
-      assert.ok(!existsSync(configPath), 'should not write empty playwright.json');
+      assert.ok(
+        !existsSync(configPath),
+        'should not write empty playwright.json'
+      );
     });
 
     it('handles lowercase browser names', () => {

clients/static-site/README.md

@@ -40,7 +40,7 @@ await run('./dist', {
   viewports: 'mobile:375x667,desktop:1920x1080',
   concurrency: 3,
 }, {
-  logger: console,
+  output: console,
   config: vizzlyConfig,
   services: serviceContainer,
 });