Commit 568d2a2
authored
🐛 Fix storybook story URL capture and add preview upload (#229)
## Summary
- **Fix story URL in screenshot properties:** `captureAndSendScreenshot`
was sending the `iframe.html?id=...` URL (what Playwright navigates to)
as the `url` property. This URL doesn't render in iframes on the
dashboard. Now converts it to the proper Storybook story path format
(`?path=/story/...`) via a new `toStoryUrl()` helper.
- **Add preview upload to Storybook CI:** Added an "Upload preview" step
to the Storybook SDK E2E workflow, matching what the static-site SDK
already does.
- **Fix test mocks:** Updated `screenshot.test.js` mocks to use the real
`iframe.html` URL (matching what `page.url()` actually returns) and
added `story.id` to mock objects. Added tests for the new `toStoryUrl`
function.
## Test plan
- [x] `screenshot.test.js` — all 11 tests pass
- [ ] Verify story URLs render correctly in Vizzly dashboard iframes
- [ ] Verify Storybook preview upload works in CI1 parent 8d16687 commit 568d2a2
3 files changed
Lines changed: 37 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
190 | 197 | | |
191 | 198 | | |
192 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
90 | 94 | | |
91 | | - | |
92 | | - | |
93 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
94 | 102 | | |
95 | 103 | | |
96 | | - | |
97 | 104 | | |
98 | 105 | | |
99 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
100 | 110 | | |
101 | 111 | | |
102 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
103 | 116 | | |
104 | 117 | | |
105 | | - | |
106 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
107 | 124 | | |
108 | 125 | | |
109 | 126 | | |
| |||
0 commit comments