Skip to content

Commit 6132231

Browse files
committed
🔧 Fix SDK E2E CI workflow
- Use Puppeteer browser caching instead of Playwright (both plugins use Puppeteer) - Add example-storybook build step before running E2E tests
1 parent d96e05f commit 6132231

1 file changed

Lines changed: 24 additions & 20 deletions

File tree

.github/workflows/sdk-e2e.yml

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -145,22 +145,26 @@ jobs:
145145
working-directory: ./clients/storybook
146146
run: npm install
147147

148-
- name: Get Playwright version
148+
- name: Get Puppeteer version
149149
working-directory: ./clients/storybook
150-
id: playwright-version
151-
run: echo "version=$(npx playwright --version | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT
150+
id: puppeteer-version
151+
run: echo "version=$(node -p "require('puppeteer/package.json').version")" >> $GITHUB_OUTPUT
152152

153-
- name: Cache Playwright browsers
153+
- name: Cache Puppeteer browsers
154154
uses: actions/cache@v4
155-
id: playwright-cache
155+
id: puppeteer-cache
156156
with:
157-
path: ~/.cache/ms-playwright
158-
key: playwright-${{ steps.playwright-version.outputs.version }}-chromium
157+
path: ~/.cache/puppeteer
158+
key: puppeteer-${{ steps.puppeteer-version.outputs.version }}-chrome
159159

160-
- name: Install Playwright browsers
161-
if: steps.playwright-cache.outputs.cache-hit != 'true'
160+
- name: Install Puppeteer browsers
161+
if: steps.puppeteer-cache.outputs.cache-hit != 'true'
162162
working-directory: ./clients/storybook
163-
run: npx playwright install chromium --with-deps
163+
run: npx puppeteer browsers install chrome
164+
165+
- name: Build example-storybook
166+
working-directory: ./clients/storybook/example-storybook
167+
run: npm install && npm run build-storybook
164168

165169
- name: Run E2E tests (TDD mode)
166170
working-directory: ./clients/storybook
@@ -202,22 +206,22 @@ jobs:
202206
working-directory: ./clients/static-site
203207
run: npm install
204208

205-
- name: Get Playwright version
209+
- name: Get Puppeteer version
206210
working-directory: ./clients/static-site
207-
id: playwright-version
208-
run: echo "version=$(npx playwright --version | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT
211+
id: puppeteer-version
212+
run: echo "version=$(node -p "require('puppeteer/package.json').version")" >> $GITHUB_OUTPUT
209213

210-
- name: Cache Playwright browsers
214+
- name: Cache Puppeteer browsers
211215
uses: actions/cache@v4
212-
id: playwright-cache
216+
id: puppeteer-cache
213217
with:
214-
path: ~/.cache/ms-playwright
215-
key: playwright-${{ steps.playwright-version.outputs.version }}-chromium
218+
path: ~/.cache/puppeteer
219+
key: puppeteer-${{ steps.puppeteer-version.outputs.version }}-chrome
216220

217-
- name: Install Playwright browsers
218-
if: steps.playwright-cache.outputs.cache-hit != 'true'
221+
- name: Install Puppeteer browsers
222+
if: steps.puppeteer-cache.outputs.cache-hit != 'true'
219223
working-directory: ./clients/static-site
220-
run: npx playwright install chromium --with-deps
224+
run: npx puppeteer browsers install chrome
221225

222226
- name: Run E2E tests (TDD mode)
223227
working-directory: ./clients/static-site

0 commit comments

Comments
 (0)