Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sdk-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ jobs:
id: playwright-cache
with:
path: ~/.cache/ms-playwright
key: playwright-${{ steps.playwright-version.outputs.version }}-chromium
key: playwright-${{ steps.playwright-version.outputs.version }}-ember-chromium-v2

- name: Install Playwright browsers
if: steps.playwright-cache.outputs.cache-hit != 'true'
Expand Down
26 changes: 19 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
"@tanstack/react-query": "^5.90.11",
"@types/node": "^25.0.2",
"@vitejs/plugin-react": "^5.0.3",
"@vizzly-testing/observatory": "^0.3.0",
"@vizzly-testing/observatory": "^0.3.3",
"autoprefixer": "^10.4.21",
"babel-plugin-transform-remove-console": "^6.9.4",
"postcss": "^8.5.6",
Expand Down
54 changes: 49 additions & 5 deletions src/reporter/src/components/comparison/fullscreen-viewer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
DocumentMagnifyingGlassIcon,
InformationCircleIcon,
ListBulletIcon,
MapPinIcon,
} from '@heroicons/react/24/outline';
import {
ApprovalButtonGroup,
Expand Down Expand Up @@ -101,6 +102,7 @@ function FullscreenViewerInner({
let [showInspector, setShowInspector] = useState(false);
let [queueFilter, setQueueFilter] = useState('needs-review');
let [_showBaseline, setShowBaseline] = useState(true);
let [showRegions, setShowRegions] = useState(false);

let { zoom, setZoom } = useZoom('fit');
let { isActive: isReviewMode } = useReviewMode();
Expand All @@ -111,7 +113,7 @@ function FullscreenViewerInner({
// Toggle inspector (closes other panels)
let toggleInspector = useCallback(() => {
setShowInspector(prev => !prev);
}, []);
}, [setShowInspector]);

// Transform comparisons for queue display
// Map CLI status to Observatory result format
Expand Down Expand Up @@ -291,7 +293,7 @@ function FullscreenViewerInner({
setViewMode(current =>
current === VIEW_MODES.OVERLAY ? VIEW_MODES.TOGGLE : VIEW_MODES.OVERLAY
);
}, []);
}, [setViewMode]);

// Toggle handler for 'd' - toggles diff overlay or baseline/current
let handleDiffToggle = useCallback(() => {
Expand All @@ -300,7 +302,7 @@ function FullscreenViewerInner({
} else {
setShowDiffOverlay(prev => !prev);
}
}, [viewMode]);
}, [viewMode, setShowBaseline, setShowDiffOverlay]);

// Review mode shortcuts
let reviewModeShortcuts = useMemo(
Expand All @@ -320,6 +322,7 @@ function FullscreenViewerInner({
onReject,
cycleViewMode,
handleDiffToggle,
setViewMode,
]
);

Expand Down Expand Up @@ -352,12 +355,25 @@ function FullscreenViewerInner({
toggleInspector();
}
break;
case 'g':
if (!e.metaKey && !e.ctrlKey) {
e.preventDefault();
setShowRegions(prev => !prev);
}
break;
}
};

window.addEventListener('keydown', handleKeyDown);
return () => window.removeEventListener('keydown', handleKeyDown);
}, [canNavigate, handlePrevious, handleNext, onClose, toggleInspector]);
}, [
canNavigate,
handlePrevious,
handleNext,
onClose,
toggleInspector,
setShowRegions,
]);

// Scroll active queue item into view
useEffect(() => {
Expand All @@ -381,7 +397,7 @@ function FullscreenViewerInner({
behavior: 'smooth',
});
}
}, []);
}, [activeQueueItemRef.current]);

if (!comparison) {
return (
Expand Down Expand Up @@ -523,6 +539,20 @@ function FullscreenViewerInner({
<ListBulletIcon className="w-5 h-5 pointer-events-none" />
</button>

{/* Regions toggle - only show if comparison has regions */}
{comparison?.confirmedRegions?.length > 0 && (
<button
type="button"
onClick={() => setShowRegions(!showRegions)}
className={`p-2 rounded-md transition-colors ${showRegions ? 'bg-emerald-500/15 text-emerald-400' : 'text-slate-400 hover:text-white hover:bg-slate-800/60'}`}
title="Show Regions (G)"
aria-label="Toggle regions"
data-testid="toggle-regions-btn"
>
<MapPinIcon className="w-5 h-5 pointer-events-none" />
</button>
)}

<button
type="button"
onClick={toggleInspector}
Expand Down Expand Up @@ -661,6 +691,7 @@ function FullscreenViewerInner({
onOnionSkinChange={setOnionSkinPosition}
zoom={zoom}
disableLoadingOverlay={true}
showRegions={showRegions}
className="w-full h-full"
/>
</main>
Expand Down Expand Up @@ -793,6 +824,19 @@ function FullscreenViewerInner({
<InformationCircleIcon className="w-5 h-5 pointer-events-none" />
</button>

{/* Regions toggle - mobile */}
{comparison?.confirmedRegions?.length > 0 && (
<button
type="button"
onClick={() => setShowRegions(!showRegions)}
className={`flex items-center justify-center p-2.5 rounded-lg transition-colors ${showRegions ? 'bg-emerald-500/15 text-emerald-400' : 'text-slate-400 hover:text-white hover:bg-slate-800/60 active:bg-slate-700/60'}`}
aria-label="Toggle regions"
data-testid="mobile-toggle-regions-btn"
>
<MapPinIcon className="w-5 h-5 pointer-events-none" />
</button>
)}

{canDelete && onDelete && (
<button
type="button"
Expand Down
16 changes: 16 additions & 0 deletions src/reporter/src/components/comparison/screenshot-display.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ExclamationTriangleIcon } from '@heroicons/react/24/outline';
import {
HotSpotOverlay,
OnionSkinMode,
OverlayMode,
ToggleView,
Expand All @@ -23,6 +24,8 @@ export function ScreenshotDisplay({
// Zoom support
zoom = 'fit',
className = '',
// Region overlay
showRegions = false,
}) {
const [imageErrors, setImageErrors] = useState(new Set());
const [imageLoadStates, setImageLoadStates] = useState(new Map());
Expand Down Expand Up @@ -305,6 +308,19 @@ export function ScreenshotDisplay({
onDiffToggle={onDiffToggle}
/>
)}

{/* Region overlay - shows confirmed regions (green boxes) */}
{showRegions && comparison?.confirmedRegions?.length > 0 && (
<HotSpotOverlay
confirmed={comparison.confirmedRegions}
candidates={[]}
imageWidth={naturalImageSize.width}
imageHeight={naturalImageSize.height}
showConfirmed={true}
showCandidates={false}
disabled={true}
/>
)}
</div>
</div>

Expand Down
15 changes: 9 additions & 6 deletions src/reporter/src/components/dashboard/dashboard-filters.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,18 @@ function IconDropdown({
onChange(val);
setIsOpen(false);
},
[onChange]
[onChange, setIsOpen]
);

// Close on outside click
let handleBlur = useCallback(e => {
if (!dropdownRef.current?.contains(e.relatedTarget)) {
setIsOpen(false);
}
}, []);
let handleBlur = useCallback(
e => {
if (!dropdownRef.current?.contains(e.relatedTarget)) {
setIsOpen(false);
}
},
[dropdownRef.current?.contains, setIsOpen]
);

return (
// biome-ignore lint/a11y/noStaticElementInteractions: dropdown container needs blur handler
Expand Down
4 changes: 2 additions & 2 deletions src/reporter/src/components/views/comparisons-view.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export default function ComparisonsView() {
},
});
},
[acceptMutation, addToast]
[acceptMutation, addToast, setLoadingStates]
);

// Reject a single comparison
Expand All @@ -179,7 +179,7 @@ export default function ComparisonsView() {
},
});
},
[rejectMutation, addToast]
[rejectMutation, addToast, setLoadingStates]
);

let handleAcceptAll = useCallback(async () => {
Expand Down
Loading
Loading