Skip to content

🐛 Unblock CLI dependency update PR#248

Merged
Robdel12 merged 1 commit into
mainfrom
fix/cli-pr-246
Apr 30, 2026
Merged

🐛 Unblock CLI dependency update PR#248
Robdel12 merged 1 commit into
mainfrom
fix/cli-pr-246

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

Summary

Verification

  • npm ci
  • npm run lint
  • npm test

Supersedes #246 because the Dependabot branch is not maintainer-editable.

Carry forward the Dependabot lockfile update and fix the Biome 2.4.13 lint findings so the dependency upgrade can merge cleanly.
@vizzly-testing
Copy link
Copy Markdown

Vizzly - Visual Test Results

CLI Reporter - 1 change needs review
Status Count
Passed 18
Changed 1
Auto-approved 18
Changes needing review (1)

fullscreen-viewer · Firefox · 375×667 · 78.5% diff

fullscreen-viewer

Review changes

CLI TUI - Approved

5 comparisons, no changes detected.

View build


fix/cli-pr-246 · 42d30ed7

@claude
Copy link
Copy Markdown

claude Bot commented Apr 30, 2026

Code Review

Overview

This PR carries forward the Dependabot lockfile bump of Biome from 2.4.12 → 2.4.13 and fixes the lint findings it surfaces — all of which are optional-chaining style cleanups. It's a focused, low-risk maintenance change.


Code Quality

Optional chaining refactors — all 11 occurrences are semantically equivalent to the original two-part null guards (!x || !x.y!x?.y). No logic changes.

One worth a second look in screenshot-display.jsx:

// Before
if (!container || !image || !image.naturalWidth) return;
// After
if (!container || !image?.naturalWidth) return;

The implicit merge of !image into the optional chain is correct — !image?.naturalWidth is true when image is null/undefined — but it quietly removes an explicit guard. Fine here since the behaviour is identical, just worth noting for reviewers.

In hotspot-coverage.js, the length check after the optional chain is safe:

if (!hotspotAnalysis?.regions || hotspotAnalysis.regions.length === 0) {

If hotspotAnalysis?.regions is falsy we short-circuit before the length access, so no runtime-error risk.

Type declaration re-ordering (src/types/sdk.d.ts) is purely alphabetical — no functional impact.


Potential Issues

None. Every change is a mechanical lint fix with no behaviour difference.


Performance / Security

No concerns. Pure style changes driven by Biome's updated lint rules.


Test Coverage

No test changes needed — these are equivalent rewrites, not logic changes. The PR description confirms npm ci, npm run lint, and npm test all pass, which is the right verification bar for this kind of change.


Summary

Clean, minimal PR. All optional-chaining substitutions are correct, the lockfile bump is straightforward, and there are no hidden behaviour changes. Approved — safe to merge.

@Robdel12 Robdel12 merged commit ea4946d into main Apr 30, 2026
28 of 30 checks passed
@Robdel12 Robdel12 deleted the fix/cli-pr-246 branch April 30, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant