♻️ Harden CLI architecture and test coverage#255
Closed
Robdel12 wants to merge 1 commit into
Closed
Conversation
Consolidates stale service boundaries, removes dead compatibility modules, and tightens CLI/SDK/plugin behavior around observable outcomes. Adds regression coverage for command flows, local server behavior, SDK config updates, uploader operations, and client integrations. Also refreshes the static-site package lock and clears production dependency audit findings.
Vizzly - Visual Test ResultsCLI Reporter - 3 changes need review
Changes needing review (3)dashboard-mixed-state · Firefox · 1920×1080 · 2.7% diff dashboard-mixed-state · Firefox · 375×892 · 16.9% diff fullscreen-viewer · Firefox · 375×667 · 78.5% diff CLI TUI - 1 change needs review
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Why
This branch is a deep production-readiness pass over the CLI codebase. The goal was to turn the earlier audit into a cohesive cleanup: remove stale compatibility layers, make the runtime boundaries easier to reason about, and add tests around the behaviors users actually rely on instead of preserving implementation details.
A few things stood out in the review:
What changed
fast-xml-parser, and cleared production audit findings.Verification
npm run lintnpm run format:checknpm run test:typesnpm test(2146pass,6skipped; skipped visual tests require X11 in this environment)npm run buildgit diff --checknpm testinclients/storybooknpm testinclients/static-sitenode --test --test-reporter=spec tests/utils/sitemap.test.jsinclients/static-sitenpm audit --omit=devinclients/static-site(0 vulnerabilities)