Skip to content

♻️ Split shared config utilities#257

Merged
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-shared-utils
May 18, 2026
Merged

♻️ Split shared config utilities#257
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-shared-utils

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

@Robdel12 Robdel12 commented May 18, 2026

Why

Configuration, CI metadata, git detection, and output formatting sit underneath almost every CLI flow. They were carrying a mix of stale helpers, repeated parsing rules, and behavior that was only lightly covered by tests. That made higher-level command changes feel riskier than they should, because a small helper change could quietly affect build names, auth config, log output, or CI metadata.

This PR isolates that runtime foundation. It removes the dead build-history helper, tightens the config/runtime helpers, and adds tests around the observable values commands actually consume. Keeping this separate makes it possible to review the contract layer before reviewing command behavior built on top of it.

What Changed

  • Cleaned up shared config loading, schema validation, CI env handling, git metadata, colors, and output helpers.
  • Removed the obsolete build-history utility.
  • Tightened ConfigService behavior where it belongs with the config layer.
  • Added focused unit coverage for config, CI env, output, and git behavior.

Verification

  • npm run build
  • node --test tests/config/core.test.js tests/services/config-service.test.js tests/unit/ci-env.test.js tests/unit/output.test.js tests/utils/ci-env.test.js tests/utils/config-loader.test.js tests/utils/git.test.js

Stack

2/10 in the CLI audit stack.

Base: rd/cli-audit-sdk-helpers
Head: rd/cli-audit-shared-utils

Base automatically changed from rd/cli-audit-sdk-helpers to main May 18, 2026 19:04
Move config, runtime, and shared utility contract cleanup into the next stacked review slice.
@Robdel12 Robdel12 force-pushed the rd/cli-audit-shared-utils branch from 78a0d72 to 4120b65 Compare May 18, 2026 19:07
@vizzly-testing
Copy link
Copy Markdown

vizzly-testing Bot commented May 18, 2026

Vizzly - Visual Test Results

CLI Reporter - 1 change needs review
Status Count
Passed 18
Changed 1
Auto-approved 18
Changes needing review (1)

dashboard-mixed-state · Firefox · 375×892 · 28.7% diff

dashboard-mixed-state

Review changes

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/cli-audit-shared-utils · 4120b651

@Robdel12 Robdel12 merged commit 0c1d1fd into main May 18, 2026
29 of 30 checks passed
@Robdel12 Robdel12 deleted the rd/cli-audit-shared-utils branch May 18, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant