♻️ Split shared config utilities#257
Merged
Merged
Conversation
Move config, runtime, and shared utility contract cleanup into the next stacked review slice.
78a0d72 to
4120b65
Compare
Vizzly - Visual Test ResultsCLI Reporter - 1 change needs review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Configuration, CI metadata, git detection, and output formatting sit underneath almost every CLI flow. They were carrying a mix of stale helpers, repeated parsing rules, and behavior that was only lightly covered by tests. That made higher-level command changes feel riskier than they should, because a small helper change could quietly affect build names, auth config, log output, or CI metadata.
This PR isolates that runtime foundation. It removes the dead build-history helper, tightens the config/runtime helpers, and adds tests around the observable values commands actually consume. Keeping this separate makes it possible to review the contract layer before reviewing command behavior built on top of it.
What Changed
build-historyutility.ConfigServicebehavior where it belongs with the config layer.Verification
npm run buildnode --test tests/config/core.test.js tests/services/config-service.test.js tests/unit/ci-env.test.js tests/unit/output.test.js tests/utils/ci-env.test.js tests/utils/config-loader.test.js tests/utils/git.test.jsStack
2/10 in the CLI audit stack.
Base:
rd/cli-audit-sdk-helpersHead:
rd/cli-audit-shared-utils