Skip to content

✨ Split init and auth wiring#258

Merged
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-init-auth
May 18, 2026
Merged

✨ Split init and auth wiring#258
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-init-auth

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

@Robdel12 Robdel12 commented May 18, 2026

Why

The first user experience with the CLI is setup and authentication. Those commands need to fail clearly, avoid touching real user state in tests, and keep config/auth concerns explicit. Before this cleanup, init/auth coverage was uneven and a few flows were harder to reason about because setup, token handling, and command output expectations were spread across command implementations.

This PR groups the setup and identity commands together so reviewers can validate the onboarding/auth story as one slice: config inspection, init behavior, login/logout, whoami, and local context.

What Changed

  • Hardened init, config, context, login, logout, and whoami command behavior.
  • Expanded command tests around successful output, clear failure modes, and isolated CLI state.
  • Updated the CLI runner helper where the command tests needed a safer shared boundary.
  • Kept the slice focused on setup/auth rather than mixing in API, server, or uploader behavior.

Verification

  • npm run lint
  • node --test tests/commands/config-cmd.test.js tests/commands/context.test.js tests/commands/init.test.js tests/commands/login.test.js tests/commands/logout.test.js tests/commands/whoami.test.js

Stack

3/10 in the CLI audit stack.

Base: rd/cli-audit-shared-utils
Head: rd/cli-audit-init-auth

@Robdel12 Robdel12 force-pushed the rd/cli-audit-shared-utils branch from 78a0d72 to 4120b65 Compare May 18, 2026 19:07
Base automatically changed from rd/cli-audit-shared-utils to main May 18, 2026 19:10
Isolate the CLI setup, auth flow, and context command behavior into their own review slice.
@Robdel12 Robdel12 force-pushed the rd/cli-audit-init-auth branch from 847fd56 to 1bd3ce4 Compare May 18, 2026 19:11
@vizzly-testing
Copy link
Copy Markdown

vizzly-testing Bot commented May 18, 2026

Vizzly - Visual Test Results

CLI Reporter - 1 change needs review
Status Count
Passed 18
Changed 1
Auto-approved 18
Changes needing review (1)

fullscreen-viewer · Firefox · 375×667 · 78.5% diff

fullscreen-viewer

Review changes

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/cli-audit-init-auth · 1bd3ce46

@Robdel12 Robdel12 merged commit fbd32f6 into main May 18, 2026
29 of 30 checks passed
@Robdel12 Robdel12 deleted the rd/cli-audit-init-auth branch May 18, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant