✨ Split init and auth wiring#258
Merged
Merged
Conversation
78a0d72 to
4120b65
Compare
Isolate the CLI setup, auth flow, and context command behavior into their own review slice.
847fd56 to
1bd3ce4
Compare
Vizzly - Visual Test ResultsCLI Reporter - 1 change needs review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
The first user experience with the CLI is setup and authentication. Those commands need to fail clearly, avoid touching real user state in tests, and keep config/auth concerns explicit. Before this cleanup, init/auth coverage was uneven and a few flows were harder to reason about because setup, token handling, and command output expectations were spread across command implementations.
This PR groups the setup and identity commands together so reviewers can validate the onboarding/auth story as one slice: config inspection, init behavior, login/logout, whoami, and local context.
What Changed
init,config,context,login,logout, andwhoamicommand behavior.Verification
npm run lintnode --test tests/commands/config-cmd.test.js tests/commands/context.test.js tests/commands/init.test.js tests/commands/login.test.js tests/commands/logout.test.js tests/commands/whoami.test.jsStack
3/10 in the CLI audit stack.
Base:
rd/cli-audit-shared-utilsHead:
rd/cli-audit-init-auth