Skip to content

✨ Split API review commands#259

Merged
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-api-review
May 18, 2026
Merged

✨ Split API review commands#259
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-api-review

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

@Robdel12 Robdel12 commented May 18, 2026

Why

The API-facing commands are where users inspect builds, baselines, comparisons, projects, reviews, and uploads. These commands share the same risk: malformed inputs, inconsistent JSON/human output, and thin test coverage can make the CLI feel unreliable even when the backend is working correctly.

This PR keeps that review surface together. It focuses on the commands that translate user intent into API requests and render the response back to the terminal, with tests that verify outcomes instead of internal command wiring.

What Changed

  • Hardened api, baselines, builds, comparisons, projects, review, and upload.
  • Added shared HTTP/API test helpers for command-level tests.
  • Expanded coverage for validation, API request construction, JSON output, human output, and failure handling.
  • Kept this separate from setup/auth and server internals so command behavior can be reviewed on its own.

Verification

  • npm run lint
  • node --test tests/commands/api.test.js tests/commands/baselines.test.js tests/commands/builds.test.js tests/commands/comparisons.test.js tests/commands/projects.test.js tests/commands/review.test.js tests/commands/upload.test.js

Stack

4/10 in the CLI audit stack.

Base: rd/cli-audit-init-auth
Head: rd/cli-audit-api-review

@Robdel12 Robdel12 force-pushed the rd/cli-audit-init-auth branch from 847fd56 to 1bd3ce4 Compare May 18, 2026 19:11
Base automatically changed from rd/cli-audit-init-auth to main May 18, 2026 19:17
@Robdel12 Robdel12 force-pushed the rd/cli-audit-api-review branch from b523beb to 2826b05 Compare May 18, 2026 19:18
Group the build, baseline, comparison, project, review, and upload command changes into one reviewable slice.
@Robdel12 Robdel12 force-pushed the rd/cli-audit-api-review branch from 2826b05 to 03311ae Compare May 18, 2026 19:21
@vizzly-testing
Copy link
Copy Markdown

vizzly-testing Bot commented May 18, 2026

Vizzly - Visual Test Results

CLI Reporter - 1 change needs review
Status Count
Passed 18
Changed 1
Auto-approved 18
Changes needing review (1)

fullscreen-viewer · Firefox · 375×667 · 78.5% diff

fullscreen-viewer

Review changes

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/cli-audit-api-review · 03311ae5

@Robdel12 Robdel12 merged commit 85d69bc into main May 18, 2026
29 of 30 checks passed
@Robdel12 Robdel12 deleted the rd/cli-audit-api-review branch May 18, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant