♻️ Split server events behavior#261
Merged
Merged
Conversation
af4cde1 to
b6478de
Compare
Isolate the events dashboard wiring and its adjacent smoke tests into a dedicated review slice.
4fd0a8a to
9074055
Compare
Vizzly - Visual Test Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The events route is the live-update path for report/dashboard behavior. It is also one of the easiest places for hidden tech debt to pile up because failures often show up as stale UI, missed updates, or watchers that behave differently across environments.
This PR keeps event behavior separate from baseline/screenshot route work. That makes the review about one thing: whether local server events and adjacent dashboard/server smoke paths behave predictably.
What Changed
Verification
npm run buildnode --test tests/server/routers/events.test.js tests/server/routers/assets.test.js tests/server/routers/auth.test.js tests/server/routers/cloud-proxy.test.js tests/server/routers/config.test.js tests/server/routers/dashboard.test.js tests/server/routers/health.test.jsStack
6/10 in the CLI audit stack.
Base:
rd/cli-audit-server-baselinesHead:
rd/cli-audit-server-events