Skip to content

♻️ Split server events behavior#261

Merged
Robdel12 merged 1 commit into
rd/cli-audit-remaining-basefrom
rd/cli-audit-server-events
May 18, 2026
Merged

♻️ Split server events behavior#261
Robdel12 merged 1 commit into
rd/cli-audit-remaining-basefrom
rd/cli-audit-server-events

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

@Robdel12 Robdel12 commented May 18, 2026

Why

The events route is the live-update path for report/dashboard behavior. It is also one of the easiest places for hidden tech debt to pile up because failures often show up as stale UI, missed updates, or watchers that behave differently across environments.

This PR keeps event behavior separate from baseline/screenshot route work. That makes the review about one thing: whether local server events and adjacent dashboard/server smoke paths behave predictably.

What Changed

  • Tightened event-router behavior and related test coverage.
  • Updated dashboard filter behavior that depends on event/report state.
  • Refreshed adjacent router smoke tests so the server surface stays consistent across assets, auth, cloud proxy, config, dashboard, and health routes.

Verification

  • npm run build
  • node --test tests/server/routers/events.test.js tests/server/routers/assets.test.js tests/server/routers/auth.test.js tests/server/routers/cloud-proxy.test.js tests/server/routers/config.test.js tests/server/routers/dashboard.test.js tests/server/routers/health.test.js

Stack

6/10 in the CLI audit stack.

Base: rd/cli-audit-server-baselines
Head: rd/cli-audit-server-events

@Robdel12 Robdel12 force-pushed the rd/cli-audit-server-baselines branch from af4cde1 to b6478de Compare May 18, 2026 19:24
Base automatically changed from rd/cli-audit-server-baselines to main May 18, 2026 19:27
Isolate the events dashboard wiring and its adjacent smoke tests into a dedicated review slice.
@Robdel12 Robdel12 force-pushed the rd/cli-audit-server-events branch from 4fd0a8a to 9074055 Compare May 18, 2026 19:29
@Robdel12 Robdel12 changed the base branch from main to rd/cli-audit-remaining-base May 18, 2026 19:30
@Robdel12 Robdel12 merged commit 71e85f9 into rd/cli-audit-remaining-base May 18, 2026
18 checks passed
@Robdel12 Robdel12 deleted the rd/cli-audit-server-events branch May 18, 2026 19:30
@vizzly-testing
Copy link
Copy Markdown

vizzly-testing Bot commented May 18, 2026

Vizzly - Visual Test Results

CLI Reporter - Approved

19 comparisons, no changes detected.

View build

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/cli-audit-server-events · 90740551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant