Skip to content

♻️ Split server events behavior #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Robdel12 merged 1 commit into from
May 18, 2026
Merged

♻️ Split server events behavior #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/reporter/src/components/dashboard/dashboard-filters.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,8 @@ function getDeviceIcon(width) {
return ComputerDesktopIcon;
}

/**
* Get device label for viewport
*/
function _getDeviceLabel(viewportStr) {
let width = parseInt(viewportStr.split('×')[0], 10);
if (width <= 480) return 'Mobile';
if (width <= 1024) return 'Tablet';
return 'Desktop';
function getViewportWidth(viewport) {
return Number(viewport.split('×')[0]);
}

/**
Expand Down Expand Up @@ -299,7 +293,7 @@ export default function DashboardFilters({

// Render viewport option with device icon
let renderViewportOption = useCallback(viewport => {
let DeviceIcon = getDeviceIcon(parseInt(viewport.split('×')[0], 10));
let DeviceIcon = getDeviceIcon(getViewportWidth(viewport));
return (
<>
<DeviceIcon className="w-4 h-4 text-slate-400" />
Expand All @@ -313,7 +307,7 @@ export default function DashboardFilters({
if (value === 'all') {
return <span className="text-slate-400">All viewports</span>;
}
let DeviceIcon = getDeviceIcon(parseInt(value.split('×')[0], 10));
let DeviceIcon = getDeviceIcon(getViewportWidth(value));
return (
<span className="flex items-center gap-2">
<DeviceIcon className="w-4 h-4 text-slate-400" />
Expand Down Expand Up @@ -553,7 +547,7 @@ export default function DashboardFilters({
{selectedViewport !== 'all' && (
<ActiveFilter
label={selectedViewport}
icon={getDeviceIcon(parseInt(selectedViewport.split('×')[0], 10))}
icon={getDeviceIcon(getViewportWidth(selectedViewport))}
onRemove={() => setSelectedViewport('all')}
/>
)}
Expand Down
Loading
Loading